Overmap overhaul (step 5)

[codemime]

Continues #19518.

Closes #17638.
Closes #19635.
Fixes #19953.

Overview

In short, nice road connections become available:

....

• Any "linear" terrain can be specified in overmap specials. It now rotates in accordance with the owning special (see 62d62bc).
• Existing connections of "linear" terrains aren't overwritten when adding new connections, only get updated (see c3da59d).
• Fixed road connections (see 45ceeb9) for:

  • Cemetery
    

  • FEMA Camp

  • Hazardous Waste Sarcophagus

  • Hospital

  • Hotel

  • Mall

  • Military Bunker

  • Motel

  • Office Tower

  • Prison

  • Public Works

  • Ranch Camp

  • School

  • Sewage Treatment Plant

• No more cuts for roads on overmap borders (see 1fe7ec6).

Implementation details

• A properly rotated/connected terrain can be obtained from oter_type_t (see 62d62bc).
• Don't use string suffixes in determining connections (see dde8ef3).
• More consistency checks were added (see 6b07434 and 023ad0b).
• Various code enhancements.

JSON API changes

In overmap_special:

• Various "linear" terrains can be present in overmaps. Define "overmap": "road_..." to make an adjoined road (sewer, ant tunnel e.t.c.) of your liking. Mention its point in connections if you want to make a connection.
• terrain can now be omitted in connections when point points to an overmap of the desired type.

Example:

"overmaps": [
    { "point": [0,-1,0], "overmap": "road_end_north" }
],
"connections": [
    { "point": [0,-1,0] }
]

[AncientSion]

Wow, that is awesome. Very good job.

[kevingranade]

Yuck, this isn't your fault or anything, but it's terrible. If you have a moment please move this prototype to a header file and include it instead of declaring it here.

[codemime]

Done.

[codemime]

Added a description. All set.

[keyspace]

Tried PR branch locally. Didn't see anything not matching OP. Wasn't very thorough, though.

Some specials will need review to match road connections, but that's outside the scope.

E.g. Sarcophagus:

[keyspace]

Should the JSON API changes be announced in #19376?..

[codemime]

Should the JSON API changes be announced in #19376?..

Done. Thanks.

[pisskop]

This commit has largely destroyed the mapgens ability to generate overmap specials that can rotate; which went a long way helping both towards fitting large specials that need specific requirements to spawn and creating less static and obviously modulated overmap regions.

I question if the ability to have flush roads is worth the havoc it will cause to the immersion of the game.

[Coolthulhu]

You must be doing something wrong because I'm getting rotated specials.

[pisskop]

Perhaps I should clarify.

My own mod, PKs_rebalance, uses things like s_lot. The parking lot. Or the sai or small power station.
I put them into larger structures like the necropolis or small pregenned towns.

Amoung other examples, the above are not capable of being rotated because the game explicitly checks for several separate extensions.

• north-south
• east-west
• fourway
• northeast-southwest

being examples.

an s_lot does not have these extensions. Nor does anything I can add into the mod. Therefore, no special that includes an unrotatable terrain, which now require arbitrary tags to flag them as such, will be able to rotate for the reasons above.

That means nothing with the coregame's < s_lot >, < field >, or anything made by a 3rd party mod can be used to rotate specials.

[Coolthulhu]

That's a pretty specific example that certainly doesn't warrant the "havoc it will cause to the immersion of the game" overreaction.

Make an issue, provide an example of how you used it and how you can't use it now. Maybe it's easier to solve than it sounds.

[pisskop]

A 'specific example' implies one or two cases. Ive listed 5 here, and have plenty of room to name more.

The amount of censor placed upon the mapgen process quite literally robs mod maker's of a resource ...

When something as prominent as a field tile or a forest tile cannot be included into a rotatable special, let alone any of the custom-made, non-hardcoded terrains, its a larger problem.

[kevingranade]

Pisskop, you need to chill out your language. From your descriprion, this breaks the hell out of your mod, I agree that's a showstopper, we're definitely going to fix it, but you flying off the handle just makes me less interested in helping you, not more. Looks like the issue is caused by swapping om_direction::rotate() with oter_t::get_rotated() in overmap::draw_overmap().