[RDY] json/battery: swappable storage battery installed/removed to/from vehicle with no skill, in little time #19950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll, in little time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19407.
Details
Time reduced to 1 minute (arbitrary).
TOOL_NONEflag removed, it's only used for legacy parts that don't providerequirements- veh_type.cpp:362Both
locationandNEEDS_BATTERY_MOUNTflag left: they're used in different places:Former:
vpart_info::finalize()- in veh_type.cpp:310Latter - in
vehicle.cpp:can_mount()andcan_unmount()- respectively lines 1455 and 1534Tangent: refactor?..
Misc
PR intended as example for #19863. IMO notes should be moved to a "problem overview issue", but they're relevant for PR review, too, so remain.
Tried reworking weld-in storage batteries, too - reverted due to PR bloat. Relevant notes got eaten in the process. :/