Add circuit analysis tool quality [RDY] #17061

mugling · 2016-06-05T15:27:12Z

Adds MULTIMETER and some demonstration items. Eventually I want to use those items to complete #14708 so that some recipes are possible without the correct tools but at a severe time penalty but that is most definitely a separate PR.

Intended balance is that oscilloscope is rare and will be required for some of the high-end recipes. The bulky makeshift_oscilloscope is a more readily available alternative.

Coolthulhu · 2016-06-05T15:33:07Z

The MULTIMETER requirement needs to be skipped when uncrafting, like crucible, welders and sewing. The relevant code is at the bottom of requirements.cpp.

mugling · 2016-06-05T15:43:54Z

@Coolthulhu Fixed in eb7c46d. As per the comments in that function we could do with looking at a JSON solution at some point.

Coolthulhu · 2016-06-08T19:30:19Z

data/json/recipes/electronics/tools.json

+    "difficulty": 4,
+    "skills_required": [ "fabrication", 2 ],
+    "time": 240000,
+    "book_learn": [ [ "advanced_electronics", 4 ], [ "mag_electronics", 6 ] , [ "manual_electronics", 5 ] ],


It is used in many recipes and so should have an autolearn recipe. Can be lvl 5 or 6, but should exist.

It's not used in any at present. The multimeter is the common tool providing MULTIMETER 2. The oscilloscopes are required for a higher level of circuit analysis of MULTIMETER 3

There is no reason to craft a tool with lower qualities, unless it offers some advantages over the one with higher qualities.

digital multimeter is level 2
oscilloscope is level 3

I agree with Coolthulhu; there should be some means of bootstrapping an improvised tool with sufficient MULTIMETER quality to start this process.

I quite like the idea of not having access to a tool forcing alternate strategy (in this case dismantling electrical items for parts you are unable to craft). That said MULTIMETER 1 is reserved for a good example of an improvised multimeter and I'm open to suggestions as to this?

Coolthulhu · 2016-06-11T13:37:04Z

data/json/recipes/recipe_deconstruction.json

@@ -497,6 +497,7 @@
    "reversible": true,
    "qualities": [ { "id": "SCREW","level": 1 } ],
    "components": [
+      [ [ "small_lcd_screen", 1 ] ],


How big is small_lcd_screen supposed to be?

Well, you can get one by disassembling a PDA.

Though I also realized that LCD screens don't work well when cut up, so 1 is fine.

Coolthulhu · 2016-06-18T20:02:25Z

I'd still prefer that improvised oscilloscope not to require MULTIMETER 2:

There is no way to get MULTIMETER quality from scratch
There is no real reason to get MULTIMETER 3 over 2 right now
Improvising a multimeter (which oscilloscope is implied to contain) doesn't sound like something that requires an existing multimeter. Adding 2-3 hours to craft time to account for the multimeter improvisation would be better than requiring a working multimeter which pretty much obsoletes the oscilloscope.

mugling · 2016-06-19T08:35:53Z

There is no way to get MULTIMETER quality from scratch

(see earlier comment)
I quite like the idea of not having access to a tool forcing alternate strategy (in this case dismantling electrical items for parts you are unable to craft). That said MULTIMETER 1 is reserved for a good example of an improvised multimeter and I'm open to suggestions as to this?

There is no real reason to get MULTIMETER 3 over 2 right now

The plan is subsequent PR is to make it a requirement of the more complex electronics recipes

I'm tempted to drop makeshift oscilloscope entirely as it was supposed to be a reworked CRT television?

mugling · 2016-06-21T22:46:36Z

Where are we going with this as I want to use it to add depth to some of the vehicle installation parts as part of #17209?

Coolthulhu · 2016-06-22T14:33:07Z

Where are we going with this

Still no consensus about the makeshift oscilloscope.

When adding new restrictions, it's better to add them gradually than all at once. A new crafting quality that you have to find and can't craft is a pure restriction. Lately the game has been moving significantly in that direction and this is a common complaint on the forums.

mugling · 2016-06-22T14:54:16Z

It's tempting to just drop both oscilloscope and makeshift_oscilloscope for now and retain just multimeter. The latter isn't reasonably craftable but should be a frequent spawn?

kevingranade · 2016-06-30T03:53:28Z

data/json/recipes/electronics/components.json

+    "decomp_learn": 1,
+    "qualities" : [
+      { "id": "SCREW", "level": 1 },
+      { "id": "MULTIMETER", "level": 2 }


I'm skeptical that a multimeter is strictly required for assembling an amplifier, it's in "faster if you have one" territory, but otherwise you should be able to do something janky like find a led and resistor that has the appropriate resistance for voltage, something similar for current, etc.

kevingranade · 2016-06-30T03:59:34Z

Would MULTIMETER 1 just be a circuit tester? There's a lot of debugging you can do with that functionality without getting a reading on voltage, amperage, or resistance between two points.

If so it's a few wires (optionally some splinters or similar non conductive items as probe handles), a battery (that will essentially last forever, I'd seriously consider just treating it as a component) and either a buzzer or a led. (not an incandescent bulb, that requires significantly more power).

With a handful of resistors, you can even do one-off resistance tests by increasing the resistor value used until the LED doesn't light up any more. I'm not sure if we want to go there though, except for...

For MULTIMETER 2, if you can find a pile of resistors (e_scrap) and LEDs, you can build a crappy multimeter that lights up leds as their voltage requirements are met, and similar stuff for amperage and resistance testing. The key here is resistors are labelled with their resistance, and batteries produce pretty damn constant current/voltage, so you can use them and some LEDs to test everything else.

Obviously you need a soldering iron or similar for assembly.

Allowing that would go a LONG way toward making a multimeter a hard requirement for electronics assembly palatable.

BorkBorkGoesTheCode · 2016-09-27T08:45:58Z

Bump

mugling · 2016-11-26T19:29:19Z

Stalled, might reopen later but for now more significant priorities

mugling force-pushed the multimeter branch from eb7c46d to 3ba27a4 Compare June 6, 2016 21:50

mugling added 6 commits June 6, 2016 23:54

Adds MULTIMETER tool quality

97801b5

Add initial item drops

c1ffed2

Add dissasembly recipes

6c1f7a8

Add MUTLIMETER to demonstration recipes

e1ba134

Vehicle electrical faults require MULTIMETER

a1e4eeb

Uncrafting does not require MULTIMETER

3ba27a4

Coolthulhu reviewed Jun 8, 2016
View reviewed changes

mugling mentioned this pull request Jun 11, 2016

"Television" item represents CRTs, which are ancient even nowadays #17131

Closed

Coolthulhu reviewed Jun 11, 2016
View reviewed changes

Television fixes

276620a

mugling changed the title ~~Add circuit analysis tool quality~~ Add circuit analysis tool quality [RDY] Jun 13, 2016

mugling mentioned this pull request Jun 16, 2016

Vehicle installation requirements (part 2) [RDY] #17209

Merged

Merge branch 'master' into multimeter

91db27a

mugling added 2 commits June 22, 2016 13:11

Merge branch 'master' into multimeter

a3ad3d8

Fixup bad merge

017052f

kevingranade reviewed Jun 30, 2016
View reviewed changes

mugling closed this Nov 26, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add circuit analysis tool quality [RDY] #17061

Add circuit analysis tool quality [RDY] #17061

mugling commented Jun 5, 2016

Coolthulhu commented Jun 5, 2016

mugling commented Jun 5, 2016

Coolthulhu Jun 8, 2016

mugling Jun 8, 2016

Coolthulhu Jun 8, 2016

mugling Jun 8, 2016

Rivet-the-Zombie Jun 9, 2016

mugling Jun 9, 2016

Coolthulhu Jun 11, 2016

mugling Jun 11, 2016

Coolthulhu Jun 15, 2016

Coolthulhu commented Jun 18, 2016

mugling commented Jun 19, 2016

mugling commented Jun 21, 2016

Coolthulhu commented Jun 22, 2016

mugling commented Jun 22, 2016

kevingranade Jun 30, 2016

kevingranade commented Jun 30, 2016

BorkBorkGoesTheCode commented Sep 27, 2016

mugling commented Nov 26, 2016

Add circuit analysis tool quality [RDY] #17061

Add circuit analysis tool quality [RDY] #17061

Conversation

mugling commented Jun 5, 2016

Coolthulhu commented Jun 5, 2016

mugling commented Jun 5, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Coolthulhu commented Jun 18, 2016

mugling commented Jun 19, 2016

mugling commented Jun 21, 2016

Coolthulhu commented Jun 22, 2016

mugling commented Jun 22, 2016

Choose a reason for hiding this comment

kevingranade commented Jun 30, 2016

BorkBorkGoesTheCode commented Sep 27, 2016

mugling commented Nov 26, 2016