Add support for intensity to vitamin deficiencies [WIP] #16402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mugling
changed the title
|
Marked WIP as JSON implantation is likely to change further |
| std::vector<std::pair<efftype_id, int>> deficiency_; | ||
| std::vector<std::pair<efftype_id, int>> excess_; | ||
| std::vector<std::pair<int, std::pair<efftype_id, int>>> deficiency_; | ||
| std::vector<std::pair<int, std::pair<efftype_id, int>>> excess_; |
There was a problem hiding this comment.
These look very alike in every aspect. Could they be replaced with a single vector having values below/above zero to represent deficiency/excess respectively (as it is now)? This would prevent duplication.
|
See #16577 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resulting from discussion in #16393
The first deficiency level will have little/no penalties and exists to provide 2 days warning that you are becoming deficient (numbers subject to change).