Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the correct z coordinate for vehicle tiles. #14468

Merged
merged 1 commit into from
Dec 18, 2015

Conversation

DanmakuDan
Copy link
Contributor

Fixes #14462.

The z coordinate was hardcoded to 0, so underground parking lot cars caused the vehicle part search to fail when trying to find a part to draw.

@DanmakuDan DanmakuDan changed the title Set the z coordinate for vehicles tiles. Set the z coordinate for vehicle tiles. Dec 18, 2015
@DanmakuDan DanmakuDan changed the title Set the z coordinate for vehicle tiles. Set the correct z coordinate for vehicle tiles. Dec 18, 2015
@sparr
Copy link
Member

sparr commented Dec 18, 2015

I'm merging this because it fixes an immediate crash bug. However, this is going to fail again as soon as the player can view a different Z level than they are on. Tagging #13595 so @Coolthulhu sees this.

sparr added a commit that referenced this pull request Dec 18, 2015
Set the correct z coordinate for vehicle tiles.
@sparr sparr merged commit 1a425f5 into CleverRaven:master Dec 18, 2015
@Coolthulhu
Copy link
Contributor

Noted

Later on it will probably get view_offset.z added to the player's z position, but for now it's good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants