Closing help in character window does not clean up properly #9835
Comments
KA101
added
<Bug>
Filter filters parts by name Updated curses port to behave more like curses * Added redrawwin * Added handling of null pointer to wrefresh Moved lcmatch to game.cpp and game.h Function lcmatch was declared too many times in too many files. Since all of them included game.h already and including ui.h made little sense just for lcmatch, moved it to game.* Workaround for popup in tiles In several places in tiles build popup didn't appear for the following reason: Curses port writes to back renderer but the actual screen is not updated anywhere in cursesport.cpp. It's updated from renderer in try_update which is called from message handling routine. If screen was rewritten before message processed started again, then no matter how many calls to wrefresh were done, they were not actually printed to the screen. Only backscreen renderer changed. Update wrefresh to update actual renderer. Note that it's not placed inside of `if (win->draw)`. In e.g. when popup() calls refresh mainwin->draw is false. Refactored input_context to keep track of windows Now after input_context corrupts screen after HELP_KEYBINDING, it redraws windows that were assigned to it. As result, it fixes CleverRaven#8514, fixes CleverRaven#9835 in * Character menu (in-game) * Construction menu * Character creation menu * World creation menu * Vehicle interaction menu
This issue was closed as it appears inactive.Reducing open issues to those which are (or will) be actively worked upon helps us focus our efforts. This issue has not been deleted - it still appears in searches and if it contains relevant information you are encouraged to continue to link to it. If this issue was a bugIt should be reopened if it can be reproduced in the current build. You can obtain the most recent copy here. Please check there is not a more recent report of this bug before doing so. If no more recent report exists you should continue the discussion in this issue. If this was a feature requestIf the consensus was that the idea was good you could consider submitting an implementation via a PR. If you want to comment further please do so here as opposed to opening a new issue. Before posting check nobody has already made the same point and consider whether your comments are likely to lead to an implementation. If you have doubts about either consider instead voting for the issue If you want to work on this issueThen either assign it to yourself or if you are unable to do so claim it via adding a comment. Please don't assign others or make a general request for action. |
When you closed the keybinding menu / help window, it does not get cleaned up properly, leaving a black rectangle where the window was.
I use version 86b0547 on GNU/Linux, ncurses build.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: