Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taekwondo buffs are always working despite wielding something. #72179

Closed
Lupinos opened this issue Mar 5, 2024 · 3 comments
Closed

Taekwondo buffs are always working despite wielding something. #72179

Lupinos opened this issue Mar 5, 2024 · 3 comments
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.

Comments

@Lupinos
Copy link

Lupinos commented Mar 5, 2024

Describe the bug

图片
By its description, I think taekwondo buffs should not be available if you are wielding anything.
I check the code and find:
图片
Here, this piece of code make 'valid_melee' always true whether you wield anything or not. I guess 'valid_melee' is used to check if the weapon is feasible to use the techniques or buffs, 'force_unarmed' should not affect weapons check.
If I delete the "forced_unarmed || ", it seems that it works fine.

By the way, here might be a relevant bug: If I wield anything, for example a heavy sledge. select taekwondo.Then when I smash something, the damage is calculated by sledge but the stamina cost is calculated as unarmed. I think there might be a little problem in Character::used_weapon().

Last question, if I believed I have fixed them, can I make a PR for them or should I ask anyone/make a confirmation first?

Attach save file

N/A

Steps to reproduce

About taekwondo buff:

1,create a random character, and choose taekwondo.
2,wield anything you find and choose taekwondo
3,inspect your status.

About stamina cost:
1,create a random character, and choose taekwondo.
2,spawn a heavy sledge, wield it, and choose taekwondo
3,smash something for several times.
4,see your stamina bar.

Expected behavior

1,If character wield something, he/she should not get buffs from taekwondo.
2,If character wield something heavy and smash, he should cost more stamina, or the damage should be revised.

Screenshots

No response

Versions and configuration

2ba772a

Additional context

No response

@Lupinos Lupinos added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Mar 5, 2024
@Zenefess
Copy link
Contributor

In data\json\martialarts.json, in the style_taekwondo entry, the static buff buff_taekwondo_static2 is missing the line "strictly_unarmed": true, after "unarmed_allowed": true,. Adding it in prevents buff_taekwondo_static2 from taking effect, and prevents globally affecting usage of valid_melee.

Testing:
Loaded existing save. "Unhindered" appears. Pick up freezer. "Unhindered" disappears. Drop freezer and wait a turn. "Unhindered" reappears. Repeat process with rifle. Same result.

@Zenefess
Copy link
Contributor

Further testing:
Loaded existing save and repeated above process with carving knife, then knuckle dusters. Same result as above.
Started new game and repeated above process with pocket knife. Same result as above.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Apr 12, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

2 participants