Taekwondo buffs are always working despite wielding something. #72179
Labels
(S1 - Need confirmation)
Report waiting on confirmation of reproducibility
stale
Closed for lack of activity, but still valid.
Describe the bug
By its description, I think taekwondo buffs should not be available if you are wielding anything.
I check the code and find:
Here, this piece of code make 'valid_melee' always true whether you wield anything or not. I guess 'valid_melee' is used to check if the weapon is feasible to use the techniques or buffs, 'force_unarmed' should not affect weapons check.
If I delete the "forced_unarmed || ", it seems that it works fine.
By the way, here might be a relevant bug: If I wield anything, for example a heavy sledge. select taekwondo.Then when I smash something, the damage is calculated by sledge but the stamina cost is calculated as unarmed. I think there might be a little problem in
Character::used_weapon()
.Last question, if I believed I have fixed them, can I make a PR for them or should I ask anyone/make a confirmation first?
Attach save file
N/A
Steps to reproduce
About taekwondo buff:
1,create a random character, and choose taekwondo.
2,wield anything you find and choose taekwondo
3,inspect your status.
About stamina cost:
1,create a random character, and choose taekwondo.
2,spawn a heavy sledge, wield it, and choose taekwondo
3,smash something for several times.
4,see your stamina bar.
Expected behavior
1,If character wield something, he/she should not get buffs from taekwondo.
2,If character wield something heavy and smash, he should cost more stamina, or the damage should be revised.
Screenshots
No response
Versions and configuration
2ba772a
Additional context
No response
The text was updated successfully, but these errors were encountered: