Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using a non-iso graphical overmap tileset with an iso main map misbehaves #59974

Closed
esotericist opened this issue Aug 6, 2022 · 2 comments
Closed
Labels
<Bug> This needs to be fixed Map / Mapgen Overmap, Mapgen, Map extras, Map display SDL: Tiles / Sound Tiles visual interface and sounds.

Comments

@esotericist
Copy link
Contributor

Describe the bug

using a non-isometric overmap tileset with an isometric main map results in attempting to render the overmap with an iso perspective. this is fairly non-productive.

Steps to reproduce

  1. set main map to an isometric tileset (such as smashbutton iso)
  2. set overmap to a non-isometric tileset (such as larwick)
  3. open overmap
  4. observe lack of usability

Expected behavior

i would expect a non-iso tileset to get rendered normally instead of as an isometric tileset

Screenshots

larwick, with incorrect isometric rendering
image

Versions and configuration

  • OS: Linux
    • OS Version: Distributor ID: Debian; Description: Debian GNU/Linux 11 (bullseye); Release: 11; Codename: bullseye;
  • Game Version: f85703b [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food]
    ]

Additional context

#58951 is also in play in the above screenshots.

i suspect that this issue might be related to #57123 given that there's clearly a state issue with regards to iso-ness of the currently loaded tileset(s).

@esotericist esotericist added <Bug> This needs to be fixed Map / Mapgen Overmap, Mapgen, Map extras, Map display SDL: Tiles / Sound Tiles visual interface and sounds. labels Aug 6, 2022
@mlange-42
Copy link
Contributor

The problem here is that there is only a global variable that says ISO yes or no. It is overwritten when loading the non-iso overmap.

Working on the fix currently...

@mlange-42
Copy link
Contributor

Fixed by #60283. Can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Map / Mapgen Overmap, Mapgen, Map extras, Map display SDL: Tiles / Sound Tiles visual interface and sounds.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants