Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with new main menu #58086

Closed
4 tasks done
Night-Pryanik opened this issue Jun 2, 2022 · 1 comment · Fixed by #58142
Closed
4 tasks done

Issues with new main menu #58086

Night-Pryanik opened this issue Jun 2, 2022 · 1 comment · Fixed by #58142
Assignees
Labels
<Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc.

Comments

@Night-Pryanik
Copy link
Contributor

Night-Pryanik commented Jun 2, 2022

Describe the bug

  • Scrolling down on credits/MOTD to the very end AND further down (for example, press down 3 times after you've scrolled to the very end) make the game require pressing up 3 times before text begins to scroll up;
  • There is no sound of highlighting the menus by hovering the mouse, while manual old-style switching (pressing left or right) produces sound;
  • Popup prompts like when pressing "Delete world" (Delete world and all world within?) or Really quit? are not mouse-clickable.
  • Tertiary menu options (Manage world: Foo) can be pressed by left mouse button, but you can't return to previous menu by pressing right mouse button, like in secondary menus.

Steps to reproduce

See above.

Expected behavior

See above.

Screenshots

No response

Versions and configuration

Windows 10 x64, 0.F-8778.

Additional context

No response

@Night-Pryanik Night-Pryanik added the Info / User Interface Game - player communication, menus, etc. label Jun 2, 2022
@NetSysFire NetSysFire added the <Bug> This needs to be fixed label Jun 2, 2022
@dseguin dseguin self-assigned this Jun 3, 2022
@Ezrashaw
Copy link
Contributor

Ezrashaw commented Jun 3, 2022

The scrolling issue is a result of the 'sel_line' variable not being capped at the texts end. I'm writing a pr now which changes both the 'mmenu_motd' and 'mmenu_credits' to vectors instead of plain strings. We really need an internal function like 'fold_and_print_from' that accepts a vector of strings instead of a single string separated by newlines.

dseguin added a commit that referenced this issue Jun 6, 2022
* Fixes menu scrolling bug in #58086

* Styling corrections

Co-authored-by: David Seguin <[email protected]>

* Update src/main_menu.cpp with style chnges

Co-authored-by: David Seguin <[email protected]>

* Remove redundant check from 'display_text'

Co-authored-by: David Seguin <[email protected]>
bombasticSlacks pushed a commit to bombasticSlacks/Cataclysm-DDA that referenced this issue Jun 10, 2022
* Fixes menu scrolling bug in CleverRaven#58086

* Styling corrections

Co-authored-by: David Seguin <[email protected]>

* Update src/main_menu.cpp with style chnges

Co-authored-by: David Seguin <[email protected]>

* Remove redundant check from 'display_text'

Co-authored-by: David Seguin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants