Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indefatigable and Hyperactive do not raise maximum stamina #52980

Closed
alex-p-b opened this issue Nov 23, 2021 · 2 comments · Fixed by #53603
Closed

Indefatigable and Hyperactive do not raise maximum stamina #52980

alex-p-b opened this issue Nov 23, 2021 · 2 comments · Fixed by #53603
Assignees
@wapcaplet
Labels
<Bug> This needs to be fixed Mechanics: Character / Player Character / Player mechanics Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@alex-p-b
Copy link

Describe the bug

Indefatigable and Hyperactive do not raise stamina by 25% and 40%, respectively. They instead do not affect maximum stamina whatsoever.

Steps To Reproduce

  1. Using debug mode, record maximum stamina
  2. Give yourself Indefatigable and/or Hyperactive
  3. Using debug mode, record maximum stamina after receiving aforementioned mutations. Maximum stamina will not have changed.

Expected behavior

I expected that maximum stamina would have risen after receiving Indefatigable or Hyperactive.

Screenshots

No response

Versions and configuration

OS: Windows 10
Game version: e5992d2 (tiles)
Graphics version: Tiles
Ingame language: English
Mods loaded: dda, no_npc_food, no_fungal_growth, package_bionic_professions

Additional context

No response
@wapcaplet wapcaplet added Mechanics: Character / Player Character / Player mechanics Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies <Bug> This needs to be fixed labels Nov 23, 2021
@wapcaplet
Copy link
Contributor

Confirmed. These traits' max_stamina_modifier values are supposed to affect get_cardiofit() which in turn affects get_stamina_max(), but it doesn't seem to matter - characters starting with or without these mutations have the same maximum stamina (8717, with default character template).

  • OS: Linux
    • OS Version: Distributor ID: Pop; Description: Pop!_OS 20.04 LTS; Release: 20.04; Codename: focal;
  • Game Version: 0.F-3988-g943e476770 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions]
    ]

@wapcaplet wapcaplet added the (S2 - Confirmed) Bug that's been confirmed to exist label Nov 24, 2021
@wapcaplet
Copy link
Contributor

Verified once again with some test cases I'm working on for cardio. The "Languorous" trait does affect maximum stamina but only by a rounding error (8714 versus 8717).

@wapcaplet wapcaplet self-assigned this Dec 19, 2021
@wapcaplet wapcaplet mentioned this issue Dec 19, 2021
Merged
5 tasks
wapcaplet added a commit to wapcaplet/Cataclysm-DDA that referenced this issue Dec 26, 2021
@wapcaplet
Add cardio_test.cpp
e1f193f 
This test covers several aspects of cardio fitness, stamina, and running
distance, especially related to mutations affecting cardio and stamina,
and in particular the three CARDIO traits affected by CleverRaven#52980.

Some FIXMEs are noted, where trait buffs have changed significantly
since the introduction of cardio, and may need to be rebalanced.

Several stub test cases are included to invite future collaboration.
wapcaplet added a commit to wapcaplet/Cataclysm-DDA that referenced this issue Dec 26, 2021
@wapcaplet
Add cardio_test.cpp
f16d274 
This test covers several aspects of cardio fitness, stamina, and running
distance, especially related to mutations affecting cardio and stamina,
and in particular the three CARDIO traits affected by CleverRaven#52980.

Some FIXMEs are noted, where trait buffs have changed significantly
since the introduction of cardio, and may need to be rebalanced.

Several stub test cases are included to invite future collaboration.
wapcaplet added a commit to wapcaplet/Cataclysm-DDA that referenced this issue Dec 26, 2021
@wapcaplet
Add cardio_test.cpp
71c6ca5 
This test covers several aspects of cardio fitness, stamina, and running
distance, especially related to mutations affecting cardio and stamina,
and in particular the three CARDIO traits affected by CleverRaven#52980.

Some FIXMEs are noted, where trait buffs have changed significantly
since the introduction of cardio, and may need to be rebalanced.

Several stub test cases are included to invite future collaboration.
wapcaplet added a commit to wapcaplet/Cataclysm-DDA that referenced this issue Dec 31, 2021
@wapcaplet
Add cardio_test.cpp
2d4a90c 
This test covers several aspects of cardio fitness, stamina, and running
distance, especially related to mutations affecting cardio and stamina,
and in particular the three CARDIO traits affected by CleverRaven#52980.

Some FIXMEs are noted, where trait buffs have changed significantly
since the introduction of cardio, and may need to be rebalanced.

Several stub test cases are included to invite future collaboration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wapcaplet wapcaplet

Labels
<Bug> This needs to be fixed Mechanics: Character / Player Character / Player mechanics Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow mutations to affect cardio wapcaplet/Cataclysm-DDA
2 participants
@wapcaplet @alex-p-b