Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipes in crafting in "*/ALL", but no subcategory #50710

Closed
Brambor opened this issue Aug 12, 2021 · 0 comments · Fixed by #50866
Closed

recipes in crafting in "*/ALL", but no subcategory #50710

Brambor opened this issue Aug 12, 2021 · 0 comments · Fixed by #50866
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON

Comments

@Brambor
Copy link
Contributor

Brambor commented Aug 12, 2021

Describe the bug

There are a couple of recipes in "OTHER/ALL" but not further specified in any subcategory (for example "OTHER/TOOLS" or "OTHER/ALL"). We could get the complete list, but there are some examples in screenshots.

It's not related to the "NEW!" marker, it just shows that there are uncategorized recipes.

To make the jargon clear: In crafting there are two things I mark "X/Y", I call X category and Y subcategory.

Steps To Reproduce

with given save:

  1. Load Middle Earth.zip.
  2. Go to crafting.
  3. Observe there are unread recipes in "OTHER/ALL" but not any subcategory.

with lot of time:

  1. Make an avatar able to make shown recipes (see pic).
  2. Go to the crafting menu.
  3. Observe that they are in "OTHER/ALL" but not in any subcategory e.g. "OTHER/OTHER".

by making read -> unread:

  1. Make an avatar able to make shown recipes (see pic).
  2. Go to the crafting menu.
  3. Mark all recipes read in all categories "/" except for "*/ALL"
  4. See that there are recipes in "*/ALL" but in no subcategory.

Expected behavior

Every recipe is listed in some subcategory.

Screenshots

category_1
category_2
category_3

Versions and configuration

  • OS: Windows 10
  • Game Version: 0f8bd78
  • Graphics version: Tiles
  • Ingame language: English
  • Mods loaded: basic

Additional context

It would be nice to have "mark all as unread" for debugging! Even if it is not set to anything by default to not clutter space if it would be unused feature.

Save, again: Middle Earth.zip

@Brambor Brambor changed the title crafting category mismatches recipes in crafting in "*/ALL", but no subcategory Aug 12, 2021
@actual-nh actual-nh added <Bug> This needs to be fixed [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Good First Issue This is a good first issue for a new contributor labels Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants