Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncraftable fried eggs when ingredients are in hide bag #47842

Closed
TandemElephant opened this issue Mar 2, 2021 · 1 comment · Fixed by #60885
Closed

Uncraftable fried eggs when ingredients are in hide bag #47842

TandemElephant opened this issue Mar 2, 2021 · 1 comment · Fixed by #60885
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling

Comments

@TandemElephant
Copy link

Describe the bug

Attempting to craft fried eggs when contained in a hide bag results in two errors, depending on whether the hide bag is worn or not. No issue is present when ingredients are unloaded from the bag.

Steps To Reproduce

  1. Make a player with the following items & skills:
    • hide bag
    • eggs + animal cooking oil
    • frying pan (cooking equipment)
    • planks + lighter (tools for lighting fire)
    • food handling 2
  2. Light a fire.
  3. Wear hide bag, make sure all the ingredients are in it.
  4. Try crafting fried eggs, it is interrupted by an error message: Attempted a recipe with no available components!
  5. Drop hide bag with the ingredients still in it.
  6. Try crafting fried eggs, a strange prompt appears as if you were wielding the in-progress craft beforehand (screenshot 1).
    • Options 1 and 2 result in a prompt for missing ingredients (screenshot 2). Saying yes brings up the prompt again. Continuously pressing 'Y' eventually completes the craft, and only consumes the ingredients once.
    • Options 3 and 4 result in simply dropping the in-progress fried eggs (0%). Activating it results in the same behaviour as for options 1 and 2.

Expected behavior

Normal crafting of fried eggs.

Screenshots

strange_prompt

continuous_prompt

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 2009
  • Game Version: 0.E-9867-gadceb7b [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Bionic Professions [package_bionic_professions],
    Blaze Industries [blazeindustries],
    Magiclysm [magiclysm],
    Packaging [Packaging],
    Mining Mod [Mining_Mod],
    More City Locations [cityside],
    No Rail Stations [No_Rail_Stations],
    Stats Through Skills [StatsThroughSkills],
    Arcana and Magic Items [Arcana],
    Arcana - UndeadPeople Tileset [ArcanaUDP],
    Blaze Industries - UndeadPeople Tileset [BlazeIndustriesUDP],
    Magiclysm - UndeadPeople Tileset [MagiclysmUDP],
    Mining Mod - UndeadPeople Tileset [Mining_ModUDP],
    More Locations [more_locations],
    More Locations - UndeadPeople Tileset [more_locationsUDP],
    MSX Indicators: Xotto [UDP_XOTTO_INDICATORS],
    Alternative Map Key [alt_map_key],
    More Survivor Stuff [more_survivor_stuff]
    ]

Additional context

@RenechCDDA
Copy link
Member

Still valid! It's skipping checking the contents because the hide bag is itself a comestible, which means it's count by charges.

Cataclysm-DDA/src/item.cpp

Lines 11884 to 11885 in 05fe4bd

// items counted by charges are not themselves expected to be containers
return VisitResponse::SKIP;

Should be resolved by #60885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants