Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter to search books by skill teached (for V or e menus. or both) #47530

Closed
adamkad1 opened this issue Feb 15, 2021 · 3 comments · Fixed by #48275
Closed

Filter to search books by skill teached (for V or e menus. or both) #47530

adamkad1 opened this issue Feb 15, 2021 · 3 comments · Fixed by #48275
Labels
<Enhancement / Feature> New features, or enhancements on existing stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing

Comments

@adamkad1
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Finding the exact book you need in a large pile (for npc teaching or sth) is hard as hell if you dont put notes on all your books, so i wish we could search books by skill

Describe the solution you'd like

something like b:devices which will show only books that teach devices skill

Describe alternatives you've considered

idk

Additional context

idk

@wapcaplet wapcaplet added <Enhancement / Feature> New features, or enhancements on existing <Suggestion / Discussion> Talk it out before implementing labels Feb 15, 2021
@jagoly
Copy link
Contributor

jagoly commented Feb 17, 2021

I agree this might be useful, but for now, why not just use the (R)ead menu to search for skill books? Find the book you want that way, then in the (G)rab menu search for it by name.

Also as a side note, I think a new loot zone category should be added just for skill books, similar to the Food/P.Food split. Not sure if there's already an issue for that.

@stale
Copy link

stale bot commented Mar 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Mar 20, 2021
BrettDong added a commit that referenced this issue Apr 1, 2021
* Add a filter to search books by skills they teach

* Hide books not skimmed when filtering items

The player was able to know which skill a book tech without first skim it.

* Fix typographic error

* Check non-skill by ID

name() is i18n-dependent and it may return something other than "nothing" in different languages.

Co-authored-by: Binrui Dong <[email protected]>
@BrettDong
Copy link
Member

Implemented in #48275.

BrettDong added a commit that referenced this issue Apr 5, 2021
* Add a filter to search books by skills they teach

* Hide books not skimmed when filtering items

The player was able to know which skill a book tech without first skim it.

* Fix typographic error

* Check non-skill by ID

name() is i18n-dependent and it may return something other than "nothing" in different languages.

Co-authored-by: Binrui Dong <[email protected]>
ZhilkinSerg pushed a commit that referenced this issue Apr 7, 2021
* Add a filter to search books by skills they teach

* Hide books not skimmed when filtering items

The player was able to know which skill a book tech without first skim it.

* Fix typographic error

* Check non-skill by ID

name() is i18n-dependent and it may return something other than "nothing" in different languages.

Co-authored-by: Binrui Dong <[email protected]>
ZhilkinSerg pushed a commit that referenced this issue Apr 9, 2021
* Add a filter to search books by skills they teach

* Hide books not skimmed when filtering items

The player was able to know which skill a book tech without first skim it.

* Fix typographic error

* Check non-skill by ID

name() is i18n-dependent and it may return something other than "nothing" in different languages.

Co-authored-by: Binrui Dong <[email protected]>
ZhilkinSerg pushed a commit that referenced this issue Apr 20, 2021
* Add a filter to search books by skills they teach

* Hide books not skimmed when filtering items

The player was able to know which skill a book tech without first skim it.

* Fix typographic error

* Check non-skill by ID

name() is i18n-dependent and it may return something other than "nothing" in different languages.

Co-authored-by: Binrui Dong <[email protected]>
ZhilkinSerg pushed a commit that referenced this issue Apr 20, 2021
* Add a filter to search books by skills they teach

* Hide books not skimmed when filtering items

The player was able to know which skill a book tech without first skim it.

* Fix typographic error

* Check non-skill by ID

name() is i18n-dependent and it may return something other than "nothing" in different languages.

Co-authored-by: Binrui Dong <[email protected]>
ZhilkinSerg pushed a commit that referenced this issue Apr 20, 2021
* Add a filter to search books by skills they teach

* Hide books not skimmed when filtering items

The player was able to know which skill a book tech without first skim it.

* Fix typographic error

* Check non-skill by ID

name() is i18n-dependent and it may return something other than "nothing" in different languages.

Co-authored-by: Binrui Dong <[email protected]>
ZhilkinSerg pushed a commit that referenced this issue May 28, 2021
* Add a filter to search books by skills they teach

* Hide books not skimmed when filtering items

The player was able to know which skill a book tech without first skim it.

* Fix typographic error

* Check non-skill by ID

name() is i18n-dependent and it may return something other than "nothing" in different languages.

Co-authored-by: Binrui Dong <[email protected]>
ZhilkinSerg pushed a commit that referenced this issue May 28, 2021
* Add a filter to search books by skills they teach

* Hide books not skimmed when filtering items

The player was able to know which skill a book tech without first skim it.

* Fix typographic error

* Check non-skill by ID

name() is i18n-dependent and it may return something other than "nothing" in different languages.

Co-authored-by: Binrui Dong <[email protected]>
ZhilkinSerg pushed a commit that referenced this issue May 31, 2021
* Add a filter to search books by skills they teach

* Hide books not skimmed when filtering items

The player was able to know which skill a book tech without first skim it.

* Fix typographic error

* Check non-skill by ID

name() is i18n-dependent and it may return something other than "nothing" in different languages.

Co-authored-by: Binrui Dong <[email protected]>
ZhilkinSerg pushed a commit that referenced this issue Jun 14, 2021
* Add a filter to search books by skills they teach

* Hide books not skimmed when filtering items

The player was able to know which skill a book tech without first skim it.

* Fix typographic error

* Check non-skill by ID

name() is i18n-dependent and it may return something other than "nothing" in different languages.

Co-authored-by: Binrui Dong <[email protected]>
ZhilkinSerg pushed a commit that referenced this issue Jun 14, 2021
* Add a filter to search books by skills they teach

* Hide books not skimmed when filtering items

The player was able to know which skill a book tech without first skim it.

* Fix typographic error

* Check non-skill by ID

name() is i18n-dependent and it may return something other than "nothing" in different languages.

Co-authored-by: Binrui Dong <[email protected]>
ZhilkinSerg pushed a commit that referenced this issue Jun 14, 2021
* Add a filter to search books by skills they teach

* Hide books not skimmed when filtering items

The player was able to know which skill a book tech without first skim it.

* Fix typographic error

* Check non-skill by ID

name() is i18n-dependent and it may return something other than "nothing" in different languages.

Co-authored-by: Binrui Dong <[email protected]>
ZhilkinSerg pushed a commit that referenced this issue Jun 21, 2021
* Add a filter to search books by skills they teach

* Hide books not skimmed when filtering items

The player was able to know which skill a book tech without first skim it.

* Fix typographic error

* Check non-skill by ID

name() is i18n-dependent and it may return something other than "nothing" in different languages.

Co-authored-by: Binrui Dong <[email protected]>
ZhilkinSerg pushed a commit that referenced this issue Jul 3, 2021
* Add a filter to search books by skills they teach

* Hide books not skimmed when filtering items

The player was able to know which skill a book tech without first skim it.

* Fix typographic error

* Check non-skill by ID

name() is i18n-dependent and it may return something other than "nothing" in different languages.

Co-authored-by: Binrui Dong <[email protected]>
anothersimulacrum pushed a commit to anothersimulacrum/Cataclysm-DDA that referenced this issue Jul 3, 2021
…erRaven#48275)

* Add a filter to search books by skills they teach

* Hide books not skimmed when filtering items

The player was able to know which skill a book tech without first skim it.

* Fix typographic error

* Check non-skill by ID

name() is i18n-dependent and it may return something other than "nothing" in different languages.

Co-authored-by: Binrui Dong <[email protected]>
KorGgenT pushed a commit to KorGgenT/Cataclysm-DDA that referenced this issue Jul 4, 2021
…erRaven#48275)

* Add a filter to search books by skills they teach

* Hide books not skimmed when filtering items

The player was able to know which skill a book tech without first skim it.

* Fix typographic error

* Check non-skill by ID

name() is i18n-dependent and it may return something other than "nothing" in different languages.

Co-authored-by: Binrui Dong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants