Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favorite pockets interface fix/improvement #41550

Closed
GGgatherer opened this issue Jun 24, 2020 · 1 comment · Fixed by #42055
Closed

Favorite pockets interface fix/improvement #41550

GGgatherer opened this issue Jun 24, 2020 · 1 comment · Fixed by #42055
Labels
Info / User Interface Game - player communication, menus, etc. Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA <Suggestion / Discussion> Talk it out before implementing

Comments

@GGgatherer
Copy link
Contributor

Describe the bug

If there's too much crap in a pocket, priority/whitelist section is not shown because items take all screen space.

Steps To Reproduce

Make a player, generate many small different items, put them into backpack, try setting rules for its pocket.

Expected behavior

Rules list actually visible regardless of how many items are in the pocket. This section should be at the top, not under pocket description/contents. Or maybe under pockets list - that one will most probably never have much height.

Screenshots

cataclysm-tiles_2020_06_24_09_03_29_922

Versions and configuration

  • OS: Windows 7
  • Game Version: 0.E-3478-g28fa7cb [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Aftershock [aftershock],
    Magiclysm [magiclysm],
    Alternative Map Key [alt_map_key],
    sees-player icon, retrodays [sees_player_retro],
    Stats Through Skills [StatsThroughSkills]
    ]

Additional context
@anothersimulacrum anothersimulacrum added <Suggestion / Discussion> Talk it out before implementing Info / User Interface Game - player communication, menus, etc. Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA labels Jun 24, 2020
@GGgatherer GGgatherer mentioned this issue Jul 12, 2020
Merged
KorGgenT pushed a commit that referenced this issue Jul 19, 2020
@GGgatherer
Fix #41550 - Favorite pockets menu - move options section before cont…
70028b7 
…ents section

* fix fav.pockets interface

Move priority/white/blacklists section before pocket contents section. Otherwise it cannot be seen if there are many items in a pocket.

* Update item_contents.cpp
fengjixuchui added a commit to fengjixuchui/Cataclysm-DDA that referenced this issue Jul 19, 2020
@fengjixuchui
Merge pull request #208 from CleverRaven/master
0fc4f1f 
Fix CleverRaven#41550 - Favorite pockets menu - move options section …
ussdefiant60 pushed a commit to ussdefiant60/Cataclysm-DDA that referenced this issue Jul 20, 2020
@GGgatherer @ussdefiant60
Fix CleverRaven#41550 - Favorite pockets menu - move options section …
50cdaa3 
…before contents section

* fix fav.pockets interface

Move priority/white/blacklists section before pocket contents section. Otherwise it cannot be seen if there are many items in a pocket.

* Update item_contents.cpp
@kevingranade
Copy link
Member

This issue has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/prevent-loot-from-going-into-armor/25491/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Info / User Interface Game - player communication, menus, etc. Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #41550 - fav.pockets interface in case of many items in a pocket GGgatherer/Cataclysm-DDA
3 participants
@kevingranade @anothersimulacrum @GGgatherer