Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A 7 liter volume rainbow trout is just 1 cm long? Also other wonky values #40446

Closed
Lamandus opened this issue May 11, 2020 · 0 comments · Fixed by #40454
Closed

A 7 liter volume rainbow trout is just 1 cm long? Also other wonky values #40446

Lamandus opened this issue May 11, 2020 · 0 comments · Fixed by #40454
Assignees
@KorGgenT
Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact

Comments

@Lamandus
Copy link
Contributor

Lamandus commented May 11, 2020 •
edited
Loading

Describe the bug

I am not sure if that is a work in progress but it clearly states a wrong value. Same with wrenches and other objects.

Steps To Reproduce

  1. spawn a rainbow trout and see its lengh.

Expected behavior

Being longer.

Screenshots

grafik

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1903
  • Game Version: 0.E-2023-gb5965f7 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Graphical Overmap [Graphical_Overmap],
    Fewer Farms [Fewer_Farms]
    ]

Feel free to close it immidiatelly if it's known.

Additional context
@KorGgenT KorGgenT self-assigned this May 11, 2020
@kevingranade kevingranade mentioned this issue May 11, 2020
Merged
Erozaxx pushed a commit to Erozaxx/Cataclysm-DDA that referenced this issue May 11, 2020
@spiderik
Add possibility to define average_length for monsters in JSON.
30de543 
This change will allow to define length for monsters in JSON. It complements Kevins
fix for issue CleverRaven#40446. Along with that it also implements check for quartered corpse.

references CleverRaven#40446

This commit adds definition of "average_length" from JSON and adds it as
attribute longest_side of the monster type object. Referrence is then used
to define "length" in the item generation. Utilizing Kevins' addition
to default based on the items volume.
@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact labels May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KorGgenT KorGgenT

Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix corpse length kevingranade/Cataclysm-DDA
3 participants
@Night-Pryanik @KorGgenT @Lamandus