Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Disproportionate crafting times for demon chitin and black dragon armor. #40070

Closed
anothersimulacrum opened this issue May 2, 2020 · 4 comments
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mods: Magiclysm Anything to do with the Magiclysm mod stale Closed for lack of activity, but still valid.

Comments

@anothersimulacrum
Copy link
Member

anothersimulacrum commented May 2, 2020

Describe the issue

The time costs to create black dragon and demon chitin armor are fairly disproportionate:
The time taken for black dragon armor is generally upwards of a day:
(the 340 hour ones are the suits)

data/mods/Magiclysm/recipes/dragon_black.json:    "time": "70 h",
data/mods/Magiclysm/recipes/dragon_black.json:    "time": "340 h",
data/mods/Magiclysm/recipes/dragon_black.json:    "time": "30 h",
data/mods/Magiclysm/recipes/dragon_black.json:    "time": "30 h",
data/mods/Magiclysm/recipes/dragon_black.json:    "time": "30 h",
data/mods/Magiclysm/recipes/dragon_black.json:    "time": "30 h",
data/mods/Magiclysm/recipes/dragon_black.json:    "time": "30 h",
data/mods/Magiclysm/recipes/dragon_black.json:    "time": "30 h",
data/mods/Magiclysm/recipes/dragon_black.json:    "time": "70 h",
data/mods/Magiclysm/recipes/dragon_black.json:    "time": "340 h",
data/mods/Magiclysm/recipes/dragon_black.json:    "time": "30 h",
data/mods/Magiclysm/recipes/dragon_black.json:    "time": "30 h",
data/mods/Magiclysm/recipes/dragon_black.json:    "time": "30 h",
data/mods/Magiclysm/recipes/dragon_black.json:    "time": "30 h",
data/mods/Magiclysm/recipes/dragon_black.json:    "time": "30 h",
data/mods/Magiclysm/recipes/dragon_black.json:    "time": "30 h",

While the time costs for demon chitin armor are generally much lower:
(the really long one there is horse armor)

data/mods/Magiclysm/recipes/armor.json:    "time": "4 h",
data/mods/Magiclysm/recipes/armor.json:    "time": "2 h",
data/mods/Magiclysm/recipes/armor.json:    "time": "4 h",
data/mods/Magiclysm/recipes/armor.json:    "time": "2 h 40 m",
data/mods/Magiclysm/recipes/armor.json:    "time": "2 h",
data/mods/Magiclysm/recipes/armor.json:    "time": "17 h 30 m",
data/mods/Magiclysm/recipes/armor.json:    "time": "5 h",

Expected behavior

Crafting time is somewhat similar between the two sets of armor. I don't think that it's intentional that black dragon armor takes so much time, when demon chitin does not, even if one is intended to be more complicated or harder to create than the other.

Additional context

This could totally be an invalid issue. I asked @KorGgenT about it, and he asked me to make a github issue.

@KorGgenT KorGgenT added the Mods: Magiclysm Anything to do with the Magiclysm mod label May 2, 2020
@KorGgenT
Copy link
Member

KorGgenT commented May 2, 2020

i'm suspecting the chitin armor is too short. I did the dragon armor from very approximate leatherworking articles online.

@KorGgenT
Copy link
Member

KorGgenT commented May 2, 2020

I imagined the chitin armor being worn over some kind of other armor to fill in gaps, where the armor itself just has leather straps to hold it in place, rather than a full-on leather armor like the dragonhide. I don't know exactly the impact that could have on the crafting time though.

@stale
Copy link

stale bot commented Jun 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Jun 2, 2020
@anothersimulacrum anothersimulacrum added the Crafting / Construction / Recipes Includes: Uncrafting / Disassembling label Jun 2, 2020
@stale stale bot removed the stale Closed for lack of activity, but still valid. label Jun 2, 2020
@anothersimulacrum anothersimulacrum added the stale Closed for lack of activity, but still valid. label Jun 2, 2020
@stale
Copy link

stale bot commented Jul 2, 2020

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

@stale stale bot closed this as completed Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mods: Magiclysm Anything to do with the Magiclysm mod stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

2 participants