Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair of copper jewellery needs more materials than it is made of #40046

Open
RedShakespeare opened this issue May 1, 2020 · 2 comments
Open
Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact

Comments

@RedShakespeare
Copy link
Contributor

Describe the bug

Some items such as "copper ring" or "copper necklece" needs 1 scrap copper (= 25 copper) for repair once, while they themselves are made of much less materials ( for copper ring the number is 3 copper, and for necklece it is 4).

Steps To Reproduce

  1. Get a broken copper ring and a welder.
  2. Try to repair the ring.
  3. You need at least 1 scrap copper.

Expected behavior

The materials needed for repair should be less than that to make the whole items.

Screenshots

image

image

Versions and configuration

  • OS: Win 10
  • Game Version: 0.E-1361-g6fb0324
  • Mods loaded:dda and any other mods without changing the definition of copper material

Additional context

Thought changing the "repaired_with" attribute might help.

@RedShakespeare
Copy link
Contributor Author

Tried in my own materials.json and it turns out that maybe we need a number attribute in "repaired_with", or even more choices like"repaired_with": [ [ "scrap_copper", 1 ], [ "copper", 25 ] ]

@kaol
Copy link

kaol commented May 2, 2020

I've recently opened another issue about resource usage when repairing. It's not directly related but if anyone's going to rethink this then that's another aspect of it: #39729

@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact labels May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
Development

No branches or pull requests

3 participants