Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line attack spells only damage the enemy at target #39955

Closed
martinrhan opened this issue Apr 27, 2020 · 0 comments · Fixed by #40242
Closed

Line attack spells only damage the enemy at target #39955

martinrhan opened this issue Apr 27, 2020 · 0 comments · Fixed by #40242
Labels
<Bug> This needs to be fixed Mods: Magiclysm Anything to do with the Magiclysm mod

Comments

@martinrhan
Copy link
Contributor

martinrhan commented Apr 27, 2020

Describe the bug

I tried using Lightening bolt and Mana beam, both of them are like this.

Steps To Reproduce

Just simply cast a line attck spell.

Expected behavior

Those spells should damage all enemies in the area.

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1903
  • Game Version: 0.E-1078-gb459021 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Aftershock [aftershock],
    Magiclysm [magiclysm],
    Alternative Map Key [alt_map_key],
    Graphical Overmap [Graphical_Overmap],
    No Rail Stations [No_Rail_Stations],
    DinoMod [DinoMod],
    Mythical Martial Arts [MMA],
    C.R.I.T Expansion Mod [crt_expansion],
    Stats Through Skills [StatsThroughSkills],
    SpeedyDex [speedydex],
    Stats Through Kills [stats_through_kills]
    ]

Additional context

I tried to solve this bug by my self but I cannot as I am not experiance in C++ and also not familiar with the game's code. It is very strange. I guess there should be some problem with in this function.
void spell_effect::line_attack( const spell &sp, Creature &caster, const tripoint &target ) { damage_targets( sp, caster, spell_effect_area( sp, target, spell_effect_line, caster, sp.has_flag( spell_flag::IGNORE_WALLS ) ) ); }
as function damage_targets and spell_effect_area works fine in function cone_attack and target_attack I think its not the problem. But function spell_effect_line has worked nicely in the aiming related code as when I choose target for the spell the affected area are is shown correctly. However it didn't work when executed in damage_targets, because when I cast fireball there are 30+ of sounds produced as each tile in the affected area should have sound produced, but the two line attack spells that I have tested only have one sound produced. That means only one tile was captured as the area of spell effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Mods: Magiclysm Anything to do with the Magiclysm mod
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants