-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Achievements keep tracking scores after they're completed #39879
Comments
The voiding thing is a bug. Thanks for alerting me. I was torn about how to deal with display of requirements for completed / failed achievements. So for example for the first achievement, after it's completed, the requirements could be omitted entirely, or it could be listed just as "1 zombies killed", or it could be "1/1 zombies killed" even after you kill more, or it could be the current status quo. I wasn't sure, and this was the easiest solution. I'd welcome other opinions as to the best UX. |
"1/1 zombies killed" looks neater imo, and is consistent with achievements systems in other games |
Fixes CleverRaven#39879. We now stop tracking requirement values when the achievement is completed or fails. Moreover, fixes a bug where a completed achievement could be un-completed by further changes to the underlying statistics.
Fixes CleverRaven#39879. We now stop tracking requirement values when the achievement is completed or fails. Moreover, fixes a bug where a completed achievement could be un-completed by further changes to the underlying statistics.
Fixes CleverRaven#39879. We now stop tracking requirement values when the achievement is completed or fails. Moreover, fixes a bug where a completed achievement could be un-completed by further changes to the underlying statistics.
Describe the bug
After you complete an achievement the game continues adding to the score so that it says stuff like
103/1 zombies killed
or w/e. In the case of the 'Rude Awakening' it voids your already completed achievement when you add to the score after the time has expired.Steps To Reproduce
3/1 monsters killed
, achievement marked as completed4/1 monsters killed
, achievement VOIDExpected behavior
when an achievement is completed (or failed by missing requirements) it should stop counting things for it
Screenshots
zombies killed in first minute
wait a minute kill another
Versions and configuration
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food]
]
The text was updated successfully, but these errors were encountered: