Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Achievements keep tracking scores after they're completed #39879

Closed
sick-trigger opened this issue Apr 25, 2020 · 2 comments · Fixed by #39932
Closed

Achievements keep tracking scores after they're completed #39879

sick-trigger opened this issue Apr 25, 2020 · 2 comments · Fixed by #39932

Comments

@sick-trigger
Copy link
Contributor

Describe the bug

After you complete an achievement the game continues adding to the score so that it says stuff like 103/1 zombies killed or w/e. In the case of the 'Rude Awakening' it voids your already completed achievement when you add to the score after the time has expired.

Steps To Reproduce

  1. spawn in, kill a few zombies in the first minute, 3/1 monsters killed, achievement marked as completed
  2. wait until 8:01:01, kill another zombie, 4/1 monsters killed, achievement VOID

Expected behavior

when an achievement is completed (or failed by missing requirements) it should stop counting things for it

Screenshots

zombies killed in first minute
01 Untitled
wait a minute kill another
02 Untitled

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1809
  • Game Version: 0.E-1182-g9f6568b [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food]
    ]
@jbytheway
Copy link
Contributor

The voiding thing is a bug. Thanks for alerting me.

I was torn about how to deal with display of requirements for completed / failed achievements. So for example for the first achievement, after it's completed, the requirements could be omitted entirely, or it could be listed just as "1 zombies killed", or it could be "1/1 zombies killed" even after you kill more, or it could be the current status quo. I wasn't sure, and this was the easiest solution. I'd welcome other opinions as to the best UX.

@sick-trigger
Copy link
Contributor Author

"1/1 zombies killed" looks neater imo, and is consistent with achievements systems in other games

jbytheway added a commit to jbytheway/Cataclysm-DDA that referenced this issue Apr 26, 2020
Fixes CleverRaven#39879.

We now stop tracking requirement values when the achievement is
completed or fails.  Moreover, fixes a bug where a completed achievement
could be un-completed by further changes to the underlying statistics.
jbytheway added a commit to jbytheway/Cataclysm-DDA that referenced this issue Apr 27, 2020
Fixes CleverRaven#39879.

We now stop tracking requirement values when the achievement is
completed or fails.  Moreover, fixes a bug where a completed achievement
could be un-completed by further changes to the underlying statistics.
Drewscriver pushed a commit to Drewscriver/Cataclysm-DDA that referenced this issue Apr 30, 2020
Fixes CleverRaven#39879.

We now stop tracking requirement values when the achievement is
completed or fails.  Moreover, fixes a bug where a completed achievement
could be un-completed by further changes to the underlying statistics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants