Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPCs deconstructing vehicles explode from infinite loop #35586

Closed
GGgatherer opened this issue Nov 18, 2019 · 4 comments · Fixed by #35649
Closed

NPCs deconstructing vehicles explode from infinite loop #35586

GGgatherer opened this issue Nov 18, 2019 · 4 comments · Fixed by #35649
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership

Comments

@GGgatherer
Copy link
Contributor

GGgatherer commented Nov 18, 2019

Describe the bug

I told 2 NPCs to deconstruct vehicles in VDZ (armored car and flatbed truck). When I return from supply run, they get their brains exploded because they went into infinite loop.

Steps To Reproduce

-load attached save;
-press "5" 7 or 8 times so you'll drive into tile adjacent to shelter where VDZ is
-get error messages and exploding brains.

Edit - if you stop the vehicle and go there on feet they are fine and they just follow you around, not deconstructing. Maybe something with vehicle headlights lighting their work area?

Expected behavior

NPCs not getting into loop and getting their brains out for the zombies to feast on.

Versions and configuration

  • OS: Windows 7 x64
  • Game Version: 0.D-9483-ga3b0f0f [64-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Modular Turrets [modular_turrets],
    Salvaged Robots [Salvaged_Robots],
    Alternative Map Key [alt_map_key],
    sees-player icon, retrodays [sees_player_retro],
    Stats Through Skills [StatsThroughSkills]
    ]

Additional context

Happened on 9901, updated to 9911, same thing.

crash-debug.zip
Save file was too big for attaching so here's the link

@ghost
Copy link

ghost commented Nov 21, 2019

Yeah, out of bubble, back into bubble, this is a known limitation of letting them roam around doing activities, for a turn when they are loaded into bubble, the thing they are working on might not be in the bubble yet, causing the infinite loop,

Got a few ideas on how to fix.

@Zireael07
Copy link
Contributor

Just return early if the thing is not in the bubble yet?

@ghost
Copy link

ghost commented Nov 21, 2019

Yeah, thats the simplest way, ideally id want to stash the activity smartly, then when the NPC is reloaded into bubble, pause for a few turns before resuming it, to give a chance for its targets to get loaded too.

@ghost
Copy link

ghost commented Nov 21, 2019

Oh but this particular bug might be different - the OP says that when they walk towards the NPCs the NPCs are fine, but when driving towards them, they infinite loop, interesting...

@ghost ghost self-assigned this Nov 21, 2019
@mlangsdorf mlangsdorf added <Bug> This needs to be fixed NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` labels Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants