Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Notes Off by Default #32313

Closed
Vzor- opened this issue Jul 11, 2019 · 6 comments · Fixed by #32340
Closed

Map Notes Off by Default #32313

Vzor- opened this issue Jul 11, 2019 · 6 comments · Fixed by #32340
Labels
Info / User Interface Game - player communication, menus, etc. Map / Mapgen Overmap, Mapgen, Map extras, Map display

Comments

@Vzor-
Copy link
Contributor

Vzor- commented Jul 11, 2019

Describe the bug

Currently the "Toggle Map Notes" option is off by default. This is a strange and presumably unintended change. It is very confusing for new players, and players unaware of the toggle option. If it was intended, then we can at least document and discuss the reasoning behind it here.

Evidence that this confuses people:
#31415

Steps To Reproduce

Make a game, check map. Toggle Map Notes will be off

Versions and configuration

0.D-Windows-Tiles-9308

@ZhilkinSerg
Copy link
Contributor

and players unaware of the toggle option

Eh? "Toggle Map Notes" is literally on the screen.

@Vzor-
Copy link
Contributor Author

Vzor- commented Jul 11, 2019

Lots of things are on that screen, it's map! I would suggest changing it to "Toggle Notes" (I read right past it at first) and it should really be on by default. I think most players come to use notes. When I first asked on discord, someone else was also confused and thought notes were removed/broken.

@ZhilkinSerg
Copy link
Contributor

People not reading what's displayed on the screen is really not a very good argument that something is broken.

@ZhilkinSerg ZhilkinSerg added Info / User Interface Game - player communication, menus, etc. Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Jul 11, 2019
@Vzor-
Copy link
Contributor Author

Vzor- commented Jul 11, 2019

Interface design is about making things easy, it is not 'broken' by any means. But on top of that, notes being off by default is not intuitive. If I have to manually place a note, why would it default to not showing that note to me? Default should be the state most commonly needed, how many people need to hide notes?

@NickGrease
Copy link
Contributor

It's been default on since time immemorial. If anyone needs to defend this change, it's not the people that expect it to be on, but whoever turned it off.

If someone adds a note, would it not be reasonable to automatically turn on the display of notes? Would that be any different than having default on in the first place?

@ZhilkinSerg
Copy link
Contributor

Interface design is about making things easy, it is not 'broken' by any means. But on top of that, notes being off by default is not intuitive. If I have to manually place a note, why would it default to not showing that note to me? Default should be the state most commonly needed, how many people need to hide notes?

I am not arguing about default state of this toggle. I've just got confused by "players unaware of toggle option", while the "Toggle Map Note" is on the screen.


It's been default on since time immemorial.

That is not a good argument - for years there was not a separate command to toggle map notes until it was added recently.

If anyone needs to defend this change, it's not the people that expect it to be on, but whoever turned it off.

I am not sure which change we are talking about and who's arguing about it - nobody created a one-line pull request to fix anything yet.

If someone adds a note, would it not be reasonable to automatically turn on the display of notes? Would that be any different than having default on in the first place?

I don't know - we don't have that, so you should probably go with A/B testing and tell us which is liked better.

l29ah added a commit to l29ah/Cataclysm-DDA that referenced this issue Jul 12, 2019
as used to be before the switch appeared
fixes CleverRaven#32313
KorGgenT pushed a commit to b0urgeoisie/Cataclysm-DDA that referenced this issue Jul 14, 2019
as used to be before the switch appeared
fixes CleverRaven#32313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info / User Interface Game - player communication, menus, etc. Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants