Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genetic Downward Spiral happens too often #31315

Closed
KorGgenT opened this issue Jun 10, 2019 · 1 comment · Fixed by #31430
Closed

Genetic Downward Spiral happens too often #31315

KorGgenT opened this issue Jun 10, 2019 · 1 comment · Fixed by #31430
Labels
<Bug> This needs to be fixed Mechanics: Character / Player Character / Player mechanics Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies

Comments

@KorGgenT
Copy link
Member

Describe the bug

in player::suffer() there are various things that call one_in(). these all need to be updated such that they are now accurate; genetic downward spiral appears to give you a mutation every 1 - 2 hours.

Expected behavior

bad mutations every ~12 hours. some other things in this function will probably be affected as well.

Versions and configuration

Additional context

I would have quick fixed this myself, but I think this is actually a more pervasive bug than at first glance, since I noticed the random teleport and mutation artifact passives have the same format as well.

@KorGgenT KorGgenT added <Bug> This needs to be fixed Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mechanics: Character / Player Character / Player mechanics labels Jun 10, 2019
@kevingranade
Copy link
Member

There might be a coarse adjustment we can make to have suffer() exit like so

if( !once_every( 6_sec ) ) {
    return;
}

Then we can rescale effects and move them above this exit gradually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Mechanics: Character / Player Character / Player mechanics Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants