Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-sort infinite loop/game hang #29573

Closed
Warlander opened this issue Apr 14, 2019 · 1 comment · Fixed by #34024
Closed

Auto-sort infinite loop/game hang #29573

Warlander opened this issue Apr 14, 2019 · 1 comment · Fixed by #34024
Labels
<Bug> This needs to be fixed <Crash / Freeze> Fatal bug that results in hangs or crashes. Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones (S2 - Confirmed) Bug that's been confirmed to exist
Milestone
0.E

Comments

@Warlander
Copy link

Describe the bug
When you sort items on the ground, in some circumstances game will enter infinite sorting loop and finally hang forever. I'm not sure what's the exact cause, but I'm supplying world with this bug present.

To Reproduce
Steps to reproduce the behavior (in this specific case):

  1. Download, put world in proper directory and launch it
  2. Press auto-sort key (default "O")
  3. Watch character being stuck in infinite sorting loop and finally hanging the game

Expected behavior
No infinite sorting loop or hanging happens, loot is sorted.

Versions and configuration(please complete the following information):

  • OS: Windows 7
  • Game Version: 0.D-1789-gc0d27c5
  • Graphics version: Tiles
  • Mods loaded: visible in attached world

Additional context
World file:
Matherville.zip
@KorGgenT KorGgenT added the <Crash / Freeze> Fatal bug that results in hangs or crashes. label Apr 14, 2019
@ZhilkinSerg ZhilkinSerg added the Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones label Apr 14, 2019
@ifreund ifreund added (S1 - Need confirmation) Report waiting on confirmation of reproducibility <Bug> This needs to be fixed labels Apr 14, 2019
@ifreund
Copy link
Contributor

ifreund commented Apr 14, 2019

Possibly related to #28571. I noticed that the caching in ACT_MOVE_LOOT got effectively disabled by that pr, but haven't gotten around to doing anything about it yet.

Could also be an unrelated bug though.

@ZhilkinSerg ZhilkinSerg mentioned this issue Jun 28, 2019
Closed
@ZhilkinSerg ZhilkinSerg added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Jun 28, 2019
ipcyborg added a commit to ipcyborg/Cataclysm-DDA that referenced this issue Aug 3, 2019
@ipcyborg
Rewrite activity_on_turn_move_loot using stages (sort loot activity). F…
b4fa87c 
…ixes CleverRaven#29573
@ipcyborg ipcyborg mentioned this issue Aug 3, 2019
Closed
@ipcyborg ipcyborg mentioned this issue Aug 31, 2019
Closed
@kevingranade kevingranade added this to the 0.E milestone Sep 5, 2019
ipcyborg added a commit to ipcyborg/Cataclysm-DDA that referenced this issue Sep 14, 2019
@ipcyborg
Fixed "Auto-sort infinite loop/game hang CleverRaven#29573" by using …
5a85d1f 
…activity stages.

Removed "num_processed" functions from clzones (not required).
Fixed `get_near_zone_type_for_item`: consistent usage of `range`.
Allow auto resume of ACT_MOVE_LOOT activity.
@ipcyborg ipcyborg mentioned this issue Sep 14, 2019
Merged
misterprimus pushed a commit to misterprimus/Cataclysm-DDA that referenced this issue Sep 21, 2019
@ipcyborg @misterprimus
Fixed "Auto-sort infinite loop/game hang CleverRaven#29573" by using …
e3851d9 
…activity stages.

Removed "num_processed" functions from clzones (not required).
Fixed `get_near_zone_type_for_item`: consistent usage of `range`.
Allow auto resume of ACT_MOVE_LOOT activity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Bug> This needs to be fixed <Crash / Freeze> Fatal bug that results in hangs or crashes. Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Milestone
0.E
5 participants
@kevingranade @Warlander @ifreund @ZhilkinSerg @KorGgenT