Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

completing a mission for the refugee farm doesn't "complete" it #27983

Closed
nulman opened this issue Jan 30, 2019 · 2 comments
Closed

completing a mission for the refugee farm doesn't "complete" it #27983

nulman opened this issue Jan 30, 2019 · 2 comments
Labels
<Bug> This needs to be fixed Missions Quests and missions

Comments

@nulman
Copy link

nulman commented Jan 30, 2019 •
edited
Loading

Hilton Head Island.zip

Describe the bug
completing a mission for the refugee ranch does not remove items or remove the mission form the log.
this appears to be a new behavior as i was completing missions successfully 3 days ago

To Reproduce
provided save is right in front of mission giver with required items
talk to him and complete the mission.
you can also go to the scavenger boss in the building to the north and give him 12 knife spears for the same effect

Expected behavior
the items and the mission should be removed

image

Versions and configuration(please complete the following information):

  • OS: Windows 10
  • Game Version 0.C-37192-gf53995c]
  • Graphics version Tiles
  • Mods loaded [
    "dda",
    "no_npc_food",
    "filthy_morale",
    "novitamins",
    "makeshift",
    "Medieval_Stuff",
    "More_Survival_Tools",
    "modular_turrets",
    "Salvaged_Robots",
    "Mining_Mod",
    "mutant_npcs",
    "national_guard_camp",
    "deoxymod",
    "blazemod",
    "Tanks",
    "No_Fungi",
    "more_classes_scenarios",
    "StatsThroughSkills"
    ]
@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Missions Quests and missions labels Jan 30, 2019
@SirPendrak
Copy link
Contributor

Whats more, now if you complete mission for standard NPC, you get to choose your reward, but mission will stay in your mission log, and relation between player character and NPC will not improve.

@Mcrone617
Copy link

I can also confirm this happens with NPC missions, just tested a mission via debug, giving the antibiotics gave the reward dialog, but the mission remained in the log, and relations didn't improve.

paroid01 pushed a commit to paroid01/Cataclysm-DDA that referenced this issue Feb 1, 2019
@mscarter
Fix some more mission completion dialog bugs
af61c23 
Putting the clear_mission effect into the success section of the JSON
seems to be required. Also the clear_mission effect was removing a
mission reference before the opinion modifiers could be applied.
Also, choosing training for a mission reward will automatically clear
the mission, and if the JSON forces it to clear with an effect, the
player has to pay for the training.

references CleverRaven#27972
references CleverRaven#27983
@nulman nulman closed this as completed Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Bug> This needs to be fixed Missions Quests and missions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nulman @Night-Pryanik @Mcrone617 @SirPendrak