Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lying about missions had some conversion bugs #27971

Closed
paroid01 opened this issue Jan 30, 2019 · 0 comments · Fixed by #27972
Closed

Lying about missions had some conversion bugs #27971

paroid01 opened this issue Jan 30, 2019 · 0 comments · Fixed by #27972
Labels
<Bug> This needs to be fixed Missions Quests and missions NPC / Factions NPCs, AI, Speech, Factions, Ownership

Comments

@paroid01
Copy link
Contributor

Dialog options after JSON change didn't have the same impact as before the JSON change.

  1. Failing the lie chance about completing a mission when it failed didn't have the correct impact on npc opinion
  2. Option to lie about completing a mission before actually completing it didn't appear
  3. Failing to lie about completing a mission didn't have the correct opinion impact
  4. Success at lying about completing a mission didn't lead to getting the reward
  5. Success at lying about completing a mission didn't have the correct opinion impact
  6. On mission completion, saying you need no reward didn't have the correct opinion impact
  7. On mission completion, asking for training also gave you an item reward before the training prompt
  8. Difficulty of lying about giving back equipment when begging wasn't the same after change

Steps to reproduce the behavior:

  1. Start a new game with NPCs on, default mods.
  2. Get the starter mission from the NPC
  3. Debug up your speaking skill to 20 or so to be able to succeed on lying
  4. Go through the dialog tree following all paths with the version before the change and after and compare NPC opinion and outcomes between the two versions for all paths

I expect there to be no changes to mission dialog and responses after the JSON changes. Well, there are some minor rounding changes due to JSON not quite having the same integer/float options, but those usually only change chances by 1 or 2%, so I think that's ok.

  • OS: Windows 10
  • Game Version pre change 0.C-37135-g8efc667
  • Graphics version Tiles
  • Mods loaded: Default set (DDA, No NPC needs, simplified nutrition, filthy clothing)
paroid01 pushed a commit to paroid01/Cataclysm-DDA that referenced this issue Jan 30, 2019
JSON refactoring for dialog changed some outcomes and chances with the
mission dialogs. This brings the chances and results back in line with
what they were before the JSON refactor.

Fixes CleverRaven#27971
paroid01 pushed a commit to paroid01/Cataclysm-DDA that referenced this issue Jan 31, 2019
JSON refactoring for dialog changed some outcomes and chances with the
mission dialogs. This brings the chances and results back in line with
what they were before the JSON refactor.

Fixes CleverRaven#27971
@ZhilkinSerg ZhilkinSerg added <Bug> This needs to be fixed NPC / Factions NPCs, AI, Speech, Factions, Ownership Missions Quests and missions labels Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Missions Quests and missions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants