Skip to content

Commit

Permalink
GitHub CI: ignore upload failure after build fails
Browse files Browse the repository at this point in the history
We have the GitHub CI set up to upload the binaries generated by a
failed build.  This is intended to help people debug test failures, but
when the compilation fails there is no binary to upload.  In that case,
GitHub gets distracted by the upload failure and doesn't automatically
jump to the relevant failure.

Reconfigure the upload step to ignore errors due to file not found.
  • Loading branch information
jbytheway authored and anothersimulacrum committed Jul 3, 2021
1 parent be0b5b2 commit b7dc997
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,9 @@ jobs:
- name: build and test
run: bash ./build-scripts/build.sh
- name: upload artifacts if failed
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v2
if: failure()
with:
name: cata_test
path: tests/cata_test
if-no-files-found: ignore

0 comments on commit b7dc997

Please sign in to comment.