Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): add curl and jq binaries #798

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

miton18
Copy link
Contributor

@miton18 miton18 commented Jul 4, 2024

This is the work of @chmuche
CleverCloud/clever-tools-dockerhub#6

but applied on the docker template

  • Remove the last commit which is just for testing purpose

How to test

  • build test image docker build -t cc:test templates/dockerhub/test
  • start container docker run --rm -it --entrypoint sh cc:test
  • use curl should work: curl http://example.com
  • use jq should work: echo '{"hello":"jq"}' | jq

@miton18 miton18 requested a review from a team as a code owner July 4, 2024 09:05
Copy link

github-actions bot commented Jul 4, 2024

🔎 A preview has been automatically published:

  • 🐧 linux ae689257e635b90bf37fa8e74fd646c8c0910b3343558810d16ddd42c7db5c7d
  • 🍏 macos 36d4c1d47bafd6f502ed793dd763b8753086bc485ef914d6cbd25098914b7a1e
  • 🪟 win 6715774f39837f236367db822ee3b96f92fd57eeabaf4318d2983a90f58a553e

This preview will be deleted once this PR is closed.

Copy link
Collaborator

@pdesoyres-cc pdesoyres-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but with some nitpicks and questions.

templates/dockerhub/Dockerfile Outdated Show resolved Hide resolved
templates/dockerhub/Dockerfile Outdated Show resolved Hide resolved
templates/dockerhub/Dockerfile Outdated Show resolved Hide resolved
templates/dockerhub/Dockerfile Show resolved Hide resolved
templates/dockerhub/test/Dockerfile Show resolved Hide resolved
Copy link

@chmuche chmuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I the main author of the PR, but in the wrong repo. I hope my answer are ok.

templates/dockerhub/Dockerfile Outdated Show resolved Hide resolved
templates/dockerhub/Dockerfile Outdated Show resolved Hide resolved
templates/dockerhub/test/Dockerfile Show resolved Hide resolved
@miton18 miton18 force-pushed the feat/docker-curl branch from 1755ab0 to f165509 Compare July 5, 2024 11:54
@hsablonniere hsablonniere added this to the 3.12 milestone Jan 23, 2025
@pdesoyres-cc
Copy link
Collaborator

@chmuche we're going back to this PR and we plan to merge it soon. Thanks again for contributing.

I've test the image and it works fine.

I'm wondering why we need the RUN ln -s lib lib64 instruction and if we still need it now. I'm not sure, we should remove it it this PR (Or at least, it should be in a different commit). @hsablonniere do you have any idea about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants