-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): add curl and jq binaries #798
base: master
Are you sure you want to change the base?
Conversation
🔎 A preview has been automatically published:
This preview will be deleted once this PR is closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, but with some nitpicks and questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I the main author of the PR, but in the wrong repo. I hope my answer are ok.
@chmuche we're going back to this PR and we plan to merge it soon. Thanks again for contributing. I've test the image and it works fine. I'm wondering why we need the |
f165509
to
22ca28d
Compare
This is the work of @chmuche
CleverCloud/clever-tools-dockerhub#6
but applied on the docker template
How to test
docker build -t cc:test templates/dockerhub/test
docker run --rm -it --entrypoint sh cc:test
curl
should work:curl http://example.com
jq
should work:echo '{"hello":"jq"}' | jq