Use AWS CLI v2 #81
Merged
Use AWS CLI v2 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://clever.atlassian.net/browse/INFRANG-4330
Following instructions to install at https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2-linux.html
As far as I can tell, none of the v2 breaking changes are relevant to how we use AWS CLI in CircleCI except the
docker loginone, which is changed here.Doing it this way removes any dependency on
pipandpythonin this stack, which is actually great because the newest version ofpip(the one that's installed by thatwget get-pip.py) dropped support for Python 2, and was causing errors. We could switch the line that installs Python to install Python 3 instead, but this seemed like a good place to switch to the new CLI, which is faster to install anyway.As a sanity check I ran CI with this branch of
ci-scriptsfor both a lambda and oauth. I pickedoauthbecause, besides being something that uses thedocker-publishscript that I changed, it also has some custom S3 stuff for uploading assets.Without some change (either fixing the python 3 thing or switching to v2) we get these errors in CI when installing.