-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: points rework (v1) #1663
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1663 +/- ##
===========================================
- Coverage 53.95% 42.14% -11.81%
===========================================
Files 109 110 +1
Lines 17911 17469 -442
===========================================
- Hits 9663 7363 -2300
- Misses 8248 10106 +1858
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a7f711b
to
250f2b8
Compare
250f2b8
to
408e81c
Compare
76cab2c
to
7585d39
Compare
7585d39
to
c3365be
Compare
Forgot that I cut a new `Data` on each collection so that change was useless.
This is something I never noticed, but the log of 0 is inf - so there were gaps in the lines when using log scaling!
Note: current #alloc hotspots are AMD gpu and linux processes. |
Description
A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:
Rework how time series data is stored, and remove the "conversion" intermediary step. More specifically:
DataStore
struct.ConvertedData
intermediary struct (and remove that altogether); we now have more direct access of the raw data.This has the following benefits:
TODO:
Issue
If applicable, what issue does this address?
Closes: #
Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt
)README.md
, help menu, doc pages, etc.)