Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data driven container compat #87

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Conversation

ZZZank
Copy link

@ZZZank ZZZank commented Oct 31, 2024

This PR will allow developers and experienced users to add simple container support without touching any Java code of Bogo, currently WIP.

  • scan for data in ./config/bogosorter/bogo.compat.json in game instance folder and ./bogo.compat.json in eveny valid mod jar
  • conditional support, e.g. add support for IronBackpack only when mod with modid ironbackpack is present.
  • complex condition: currently providing logical operation like not, and, or for combining multiple conditions, and advanced mod condition like RegEx matching for mod version.
  • multiple support presets: generic support, custom slot begin/end and row size, mark only, remove only, mapped
  • more dynamic "mapped" container support: currently allows using advanced condition to filter slots to be added to slot group. We might need some more adaptable Slot->ISlot mapper, blocked by Arcane archive support #82 .
  • button position setter
  • data-driven reflection, forming a "access sequence", the sequence must start with the container instance, and ends as an integer, ready for use in container support. Each access in this sequemce should be either getting a field, or invoking an instance method with no arg requirement
  • data-driven ternary operator for more flexibility
  • documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant