Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Tech Reborn compat #177

Merged
merged 8 commits into from
Aug 31, 2024
Merged

Conversation

WaitingIdly
Copy link
Collaborator

@WaitingIdly WaitingIdly commented Jun 9, 2024

changes in this PR:

  • adds compileOnly "io.github.classgraph:classgraph:4.8.165" to make it so mods that shade classgraph don't override our version in the dev environment.
  • notes what the maven repos get in a comment next to the maven repo.
  • adds the https://modmaven.dev maven repo.
  • reduces some duplication in the AbstractRecipeBuilder.validateXYZ code
  • adds compat to multiple different types of Tech Reborn processes (total of 26):
    • some basic machines: AlloySmelter, AssemblingMachine, Centrifuge, ChemicalReactor, Compressor, Extractor, Grinder, PlateBendingMachine, SolidCanningMachine, and WireMill.
    • some advanced machines: BlastFurnace, DistillationTower, ImplosionCompressor, IndustrialElectrolyzer, IndustrialGrinder, IndustrialSawmill, Scrapbox, and VacuumFreezer.
    • powergens: DieselGenerator, GasTurbine, PlasmaGenerator, SemiFluidGenerator, and ThermalGenerator.
    • some unique machines: RollingMachine, FluidReplicator, and FusionReactor.
  • adds examples file and i18n wiki keys for the above compat.
Note: this was resolved via mixin

currently, due to how the `RollingMachine` is implemented, custom recipes do not display in JEI, as they do not implement one of the specifically handled classes in `RollingMachineRecipeWrapper.create`. the recipes are still craftable, only JEI is broken. i am unsure of how to best resolve this.

@WaitingIdly WaitingIdly added the mod compat Relating to compatability with a mod or features of a mod label Jun 9, 2024
@WaitingIdly WaitingIdly force-pushed the tech-reborn branch 2 times, most recently from ab59517 to 3d41c9b Compare July 22, 2024 18:20
Copy link
Member

@brachy84 brachy84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitly reviewed all of that

repositories.gradle Outdated Show resolved Hide resolved
@brachy84 brachy84 merged commit 7a5602e into CleanroomMC:master Aug 31, 2024
@WaitingIdly WaitingIdly deleted the tech-reborn branch September 1, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod compat Relating to compatability with a mod or features of a mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants