-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Thermal Expansion compat #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitly reviewed all 7000 lines of code
|
||
public abstract class VirtualizedRegistry<R> extends NamedRegistry implements IScriptReloadable { | ||
|
||
private Collection<R> backup, scripted; | ||
private final AbstractReloadableStorage<R> recipeStorage; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im thinking it might be better to have VirtualizedRegistry
extend AbstractReloadableStorage
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the current code structure requires that VirtualizedRegistry
extends NamedRegistry
. since NamedRegistry
definitely shouldnt extend AbstractReloadableStorage
, this plan isnt viable.
changes in this PR:
.editorconfig
, and make groovy indent by 4 for RecipeBuilders, since thats how our code is formatted.RegistryDescription
./gs hand
by:-
NBTTagByteArray
.INbtIngredient
, since some fluids use NBT data.AbstractReloadableStorage
, which contains two arraylists for backup and scripted.VirtualizedRegistry
, Chisel Carving, Inspirations Anvil Smashing, Mekanism Infusion, Thaumcraft Research, and Tinker's Complement Melter.recipeBuilderMethods
for a property or if there are noregistrationMethods
.Brewer
,Centrifuge
(as standard andCentrifugeMobs
),Charger
,Compactor
,Crucible
,Enchanter
,Extruder
[*],Furnace
(as both standard andFurnacePyrolysis
),Insolator
,Precipitator
[*],Pulverizer
,Refinery
(as both standard andRefineryPotion
),Sawmill
,Smelter
,Transposer
(split intoTransposerExtract
andTransposerFill
).Coolant
,Diffuser
[*],Factorizer
,Fisher
[*] (as both standard andFisherBait
[*]),Tapper
[*] (as both standard,TapperFertilizer
[*], andTapperTree
[*]),XpCollector
[*].Compression
,Enervation
,Magmatic
,Numismatic
(as both standard andLapidary
),Reactant
,Steam
.