Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download stats badge. #297

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Add download stats badge. #297

merged 1 commit into from
Apr 25, 2024

Conversation

sodul
Copy link
Collaborator

@sodul sodul commented Apr 25, 2024

This adds a downloads stats badge to the main readme which helps show the popularity of green.

Moved the text around a bit to be consistent with other popular python packages and added the badges to the readme that is published on pypi.org.

@sodul
Copy link
Collaborator Author

sodul commented Apr 25, 2024

image

@coveralls
Copy link

coveralls commented Apr 25, 2024

Coverage Status

coverage: 95.232%. remained the same
when pulling 3b75ea1 on clumio-oss:main
into 8cabab8 on CleanCut:main.

@sodul
Copy link
Collaborator Author

sodul commented Apr 25, 2024

There is a known bug with GH actions being broken on macos-latest and python 3.8 and 3.9.

actions/setup-python#850

@sodul
Copy link
Collaborator Author

sodul commented Apr 25, 2024

Python 3.8 and 3.9 are now fixed for macos-latest but we are now getting this error on 3.8:

lxml/etree.cpython-38-darwin.so, 0x0002): symbol not found in flat namespace '_exsltDateXpathCtxtRegister'

This is completely unrelated to our changes if this is a persistent problem I can look into the issue further. My guess is that for this target the etree.cpython-38-darwin.so needs to be recompiled from sources in order to run properly. Alternatively we could target macOS 13 instead of latest for 3.8. Since it will be EOL later this year that might be the simplest thing to do.

@sodul sodul merged commit 2caf6e8 into CleanCut:main Apr 25, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants