Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work for absolute file paths #2

Closed
qgustavor opened this issue Sep 12, 2024 · 6 comments · Fixed by #3
Closed

Does not work for absolute file paths #2

qgustavor opened this issue Sep 12, 2024 · 6 comments · Fixed by #3

Comments

@qgustavor
Copy link
Contributor

Due to join being used here instead of using resolve.
qgustavor added a commit to qgustavor/dhash that referenced this issue Sep 12, 2024
@qgustavor
Use resolve instead of join
c1ec7e3 
Fixes ClaudiuCeia#2.
@qgustavor qgustavor mentioned this issue Sep 12, 2024
Merged
@qgustavor qgustavor changed the title Does not work for absolute file pathes Does not work for absolute file paths Sep 12, 2024
@qgustavor
Copy link
Contributor Author

Also it can generate hashes with 15 or less characters due to parseInt(out.join(""), 2).toString(16). I will add a fix for that in the same pull request.

@ClaudiuCeia
Copy link
Owner

Awesome, thanks @qgustavor !

ClaudiuCeia pushed a commit that referenced this issue Sep 13, 2024
@qgustavor @ClaudiuCeia
Use resolve instead of join
810c5d6 
Fixes #2.
@ClaudiuCeia
Copy link
Owner

I'll publish a new version - are you using this in a real project or were you just browsing?

@qgustavor
Copy link
Contributor Author

I'm using it to deduplicate photos in a database for a government backed project.

@ClaudiuCeia
Copy link
Owner

That sounds great! Any chance I can mention that in the README?

@qgustavor
Copy link
Contributor Author

qgustavor commented Sep 13, 2024 •
edited
Loading

That's fine. I only have the Instagram page of the project at the moment, the website is still in the works: https://www.instagram.com/pddugyn/ (I guess they removed all posts due to electoral laws requiring it since we will vote for a new mayor in October, so the city hall must not use their socials).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use resolve instead of join qgustavor/dhash
2 participants
@qgustavor @ClaudiuCeia