Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node.py: != False #242

Closed
wants to merge 1 commit into from
Closed

Update node.py: != False #242

wants to merge 1 commit into from

Conversation

galenseilis
Copy link
Contributor

I don't think != False is necessary here.

I don't think `!= False` is necessary here.
@galenseilis
Copy link
Contributor Author

Looks like the version of Sphinx might need to be updated.

@geraintpalmer
Copy link
Member

Here we are explicitly checking if self.priority_preempt is False or not. Although I believe leaving out the != False works, the other values that self.priority_preempt can take are all strings, not True, and so to be explicit and to avoid any unintended behaviour, I think this should be retained.

@galenseilis galenseilis closed this by deleting the head repository Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants