Change != None
to is not
in import_params.py
#240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python, the is not None construct is preferred over != None for several reasons:
Identity Comparison vs. Value Comparison:
is not is an identity comparison, which checks whether two objects refer to the same memory location.
!= is a value comparison, which checks whether the values of the objects are equal.
None is a Singleton:
None is a singleton object in Python, meaning there is only one instance of None in the entire program.
Using is not None leverages the identity comparison and takes advantage of the fact that there is only one None object, making it more efficient than a value comparison.
Consistency:
Using is not None is more consistent with the recommended practice of using is and is not for checking against singletons (like None).
Avoids Unintended Behavior:
Value comparisons (!=) may behave unexpectedly when dealing with objects that override the eq method, leading to potential pitfalls.
Identity comparisons (is not) are safer in such cases, as they explicitly check for object identity.