fix(terminal): failure to remove .lock file #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the runner/executor is set to `terminal` the removal of the .lock file fails if the user has setup a shell alias for the `rm(1)` command that requires confirmation (e.g.: alias rm='rm -iv'). In such case, the runner/executor does not finish and waits indefinitely for user confirmation: remove ~/.local/share/nvim/cmake-tools-tmp/.lock? This PR bypasses any alias of `rm(1)` command and also uses the `-f` flag.
Civitasv
reviewed
May 20, 2024
| @@ -542,7 +542,7 @@ end | |||
| local get_command_handling_on_exit = function() | |||
| return "echo $? > " | |||
| .. get_last_exit_code_file_path() -- write exitcode to file | |||
| .. " && rm " | |||
| .. " && \\rm -f " | |||
There was a problem hiding this comment.
It is the shortest way to bypass an alias in the shell.
There are multiple ways to do this (with pros and cons):
- prefix a back slash to disable the alias:
\rm -f - use "command":
command rm -f(will also cover the case when the user has a custom function calledrm()but some shells might not support it) - use the full path:
/bin/rm -f(not guaranteed to be the same on all distros) - quote the command: "rm" or 'rm'
command rm -rf will also be a good alternative.
There was a problem hiding this comment.
this breaks the fish shell.
I'd suggest to use the command rm -f alternative instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the runner/executor is set to
terminalthe removal of the.lockfile fails if the user has setup a shell alias for therm(1)command that requires confirmation (e.g.:alias rm='rm -iv').In such case, the runner/executor does not finish and waits indefinitely for user confirmation:
remove ~/.local/share/nvim/cmake-tools-tmp/.lock?This PR bypasses any alias of
rm(1)command and also uses the-fflag.