Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: command not ending when cmd doesnt exit successfully #225

Merged
merged 1 commit into from
May 4, 2024

Conversation

khris190
Copy link
Contributor

@khris190 khris190 commented May 3, 2024

this part is quite important expecially for tests because we want to get the exit code and delete lock even if command exits with an error code for example: when tests are failing and tests are made to fail

@khris190 khris190 changed the title fix: fix command not ending then cmd doesnt exit successfully fix: command not ending then cmd doesnt exit successfully May 4, 2024
@khris190 khris190 changed the title fix: command not ending then cmd doesnt exit successfully fix: command not ending when cmd doesnt exit successfully May 4, 2024
@Civitasv
Copy link
Owner

Civitasv commented May 4, 2024

Makes sense. I also removed the return $EXITCODE to make command shorter, is that ok?

image

@khris190
Copy link
Contributor Author

khris190 commented May 4, 2024

Makes sense. I also removed the return $EXITCODE to make command shorter, is that ok?

image

I mean depends, i had it there, so on the offchance that someone wanted that exit code, they could use it as our file handling wasn't there, My zsh shows me the exit code after the command so personally i just wanted to see what the command returned. But it doesn't really break anything if we don't have it there. I don't think anyone used that code for anything productive

@Civitasv
Copy link
Owner

Civitasv commented May 4, 2024

ok, I understand.

@Civitasv Civitasv merged commit f75ce8d into Civitasv:master May 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants