Implementing anchor heading permalinks in Playbook pages #271

mgifford · 2021-04-17T12:02:45Z

This should implement https://github.com/allejo/jekyll-anchor-headings

https://github.com/allejo/jekyll-anchor-headings

This should turn all of the persona headings into anchor headings.

github-actions · 2021-04-17T12:09:02Z

Pa11y testing results

> uswds-jekyll@ pa11y-ci:sitemap /home/runner/work/accessibility/accessibility
> pa11y-ci --sitemap http://localhost:4000/sitemap.xml --sitemap-exclude "/*.pdf"

Running Pa11y on 72 URLs:
 > http://localhost:4000/guide/glossary - 0 errors
 > http://localhost:4000/guide/events - 0 errors
 > http://localhost:4000/guide/documents - 0 errors
 > http://localhost:4000/guide/design - 0 errors
 > http://localhost:4000/guide/identity-language - 0 errors
 > http://localhost:4000/guide/introduction - 0 errors
 > http://localhost:4000/guide/organizations - 0 errors
 > http://localhost:4000/guide/history - 0 errors
 > http://localhost:4000/guide/resources - 0 errors
 > http://localhost:4000/people/daniel-mundra - 0 errors
 > http://localhost:4000/guide/training - 0 errors
 > http://localhost:4000/people/jack-haas - 0 errors
 > http://localhost:4000/people/jennifer-aube - 0 errors
 > http://localhost:4000/guide/tools - 0 errors
 > http://localhost:4000/people/jonathan-bourland - 0 errors
 > http://localhost:4000/people/luke-fretwell - 0 errors
 > http://localhost:4000/people/michelle-kang - 0 errors
 > http://localhost:4000/people/nira-datta - 0 errors
 > http://localhost:4000/people/mike-gifford - 0 errors
 > http://localhost:4000/personas/accessibility-avery - 0 errors
 > http://localhost:4000/personas/designer-darcy - 0 errors
 > http://localhost:4000/personas/engineer-emery - 0 errors
 > http://localhost:4000/personas/procurement-parker - 0 errors
 > http://localhost:4000/personas/qa-quincy - 0 errors
 > http://localhost:4000/personas/remote-raz - 0 errors
 > http://localhost:4000/playbook/AT - 0 errors
 > http://localhost:4000/playbook/ai-and-ia - 0 errors
 > http://localhost:4000/playbook/authoring - 0 errors
 > http://localhost:4000/playbook/automated-testing - 0 errors
 > http://localhost:4000/playbook/checklists - 0 errors
 > http://localhost:4000/playbook/community - 0 errors
 > http://localhost:4000/playbook/distributed-teams - 0 errors
 > http://localhost:4000/playbook/follow-global-initiatives - 0 errors
 > http://localhost:4000/playbook/manual-testing - 0 errors
 > http://localhost:4000/playbook/personalization - 0 errors
 > http://localhost:4000/playbook/practice - 0 errors
 > http://localhost:4000/playbook/pwd - 0 errors
 > http://localhost:4000/playbook/statements - 0 errors
 > http://localhost:4000/playbook/training - 0 errors
 > http://localhost:4000/posts/hello-world - 0 errors
 > http://localhost:4000/posts/gcn-accessibility-compliance-as-code - 0 errors
 > http://localhost:4000/playbook/roles - 0 errors
 > http://localhost:4000/posts/improve-government-accessibility-through-open-source - 0 errors
 > http://localhost:4000/posts/govtech-how-will-biden-transform-government-website-accessibility - 0 errors
 > http://localhost:4000/posts/at-banter-podcast - 0 errors
 > http://localhost:4000/posts/automated-accessibility-testing-leveraging-github-actions-and-pa11y-ci-with-axe - 0 errors
 > http://localhost:4000/posts/mvp-playbook - 0 errors
 > http://localhost:4000/posts/mvp-guide - 0 errors
 > http://localhost:4000/projects/drupal - 0 errors
 > http://localhost:4000/projects/uswds-color - 0 errors
 > http://localhost:4000/projects/uswds - 0 errors
 > http://localhost:4000/about - 0 errors
 > http://localhost:4000/accessibility - 0 errors
 > http://localhost:4000/agile - 0 errors
 > http://localhost:4000/calendar - 0 errors
 > http://localhost:4000/colophon - 0 errors
 > http://localhost:4000/conduct - 0 errors
 > http://localhost:4000/contact - 0 errors
 > http://localhost:4000/guide - 0 errors
 > http://localhost:4000/news/ - 0 errors
 > http://localhost:4000/join - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/license - 0 errors
 > http://localhost:4000/okrs - 0 errors
 > http://localhost:4000/open - 0 errors
 > http://localhost:4000/people - 0 errors
 > http://localhost:4000/personas - 0 errors
 > http://localhost:4000/projects - 0 errors
 > http://localhost:4000/playbook - 0 errors
 > http://localhost:4000/services - 0 errors
 > http://localhost:4000/search - 0 errors
 > http://localhost:4000/VPAT/Drupal9AccessibilityConformanceReport-December2020.html - 0 errors

✔ 72/72 URLs passed

dmundra · 2021-04-17T14:30:22Z

_layouts/personas.html

@@ -34,7 +34,8 @@
                    <img src="{{ site.baseurl }}/assets/personas/mugshots/{{ page.img }}" alt="Headshot of {{ page.title }}">
                    <h1>{{ page.title }}</h1>
                    {% endif %}
-                    {{ content }}
+                    <!--{{ content }}-->


@mgifford I think it is better to just delete this line then generate two versions of the content in the source which this might do.

I've modified this, and agree. I just wanted to to express exactly what i'd written there as a comment, not spit out the results of the comment. But not sure how to do that.

I had wanted to just show the text {{ content }} so it was more clear. what was changed. Just wasn't sure how to comment that without as you noted Daniel duplicating the content.

github-actions · 2021-04-17T15:16:27Z

Pa11y testing results

> uswds-jekyll@ pa11y-ci:sitemap /home/runner/work/accessibility/accessibility
> pa11y-ci --sitemap http://localhost:4000/sitemap.xml --sitemap-exclude "/*.pdf"

Running Pa11y on 72 URLs:
 > http://localhost:4000/guide/glossary - 0 errors
 > http://localhost:4000/guide/documents - 0 errors
 > http://localhost:4000/guide/events - 0 errors
 > http://localhost:4000/guide/design - 0 errors
 > http://localhost:4000/guide/identity-language - 0 errors
 > http://localhost:4000/guide/introduction - 0 errors
 > http://localhost:4000/guide/organizations - 0 errors
 > http://localhost:4000/guide/history - 0 errors
 > http://localhost:4000/guide/training - 0 errors
 > http://localhost:4000/people/daniel-mundra - 0 errors
 > http://localhost:4000/guide/tools - 0 errors
 > http://localhost:4000/guide/resources - 0 errors
 > http://localhost:4000/people/jack-haas - 0 errors
 > http://localhost:4000/people/jennifer-aube - 0 errors
 > http://localhost:4000/people/luke-fretwell - 0 errors
 > http://localhost:4000/people/jonathan-bourland - 0 errors
 > http://localhost:4000/people/michelle-kang - 0 errors
 > http://localhost:4000/people/mike-gifford - 0 errors
 > http://localhost:4000/people/nira-datta - 0 errors
 > http://localhost:4000/personas/accessibility-avery - 0 errors
 > http://localhost:4000/personas/designer-darcy - 0 errors
 > http://localhost:4000/personas/engineer-emery - 0 errors
 > http://localhost:4000/personas/qa-quincy - 0 errors
 > http://localhost:4000/personas/remote-raz - 0 errors
 > http://localhost:4000/personas/procurement-parker - 0 errors
 > http://localhost:4000/playbook/AT - 0 errors
 > http://localhost:4000/playbook/ai-and-ia - 0 errors
 > http://localhost:4000/playbook/automated-testing - 0 errors
 > http://localhost:4000/playbook/checklists - 0 errors
 > http://localhost:4000/playbook/community - 0 errors
 > http://localhost:4000/playbook/authoring - 0 errors
 > http://localhost:4000/playbook/distributed-teams - 0 errors
 > http://localhost:4000/playbook/personalization - 0 errors
 > http://localhost:4000/playbook/follow-global-initiatives - 0 errors
 > http://localhost:4000/playbook/practice - 0 errors
 > http://localhost:4000/playbook/manual-testing - 0 errors
 > http://localhost:4000/playbook/pwd - 0 errors
 > http://localhost:4000/playbook/statements - 0 errors
 > http://localhost:4000/posts/hello-world - 0 errors
 > http://localhost:4000/playbook/training - 0 errors
 > http://localhost:4000/posts/gcn-accessibility-compliance-as-code - 0 errors
 > http://localhost:4000/playbook/roles - 0 errors
 > http://localhost:4000/posts/govtech-how-will-biden-transform-government-website-accessibility - 0 errors
 > http://localhost:4000/posts/improve-government-accessibility-through-open-source - 0 errors
 > http://localhost:4000/posts/automated-accessibility-testing-leveraging-github-actions-and-pa11y-ci-with-axe - 0 errors
 > http://localhost:4000/posts/at-banter-podcast - 0 errors
 > http://localhost:4000/posts/mvp-playbook - 0 errors
 > http://localhost:4000/posts/mvp-guide - 0 errors
 > http://localhost:4000/projects/drupal - 0 errors
 > http://localhost:4000/projects/uswds-color - 0 errors
 > http://localhost:4000/projects/uswds - 0 errors
 > http://localhost:4000/about - 0 errors
 > http://localhost:4000/accessibility - 0 errors
 > http://localhost:4000/agile - 0 errors
 > http://localhost:4000/calendar - 0 errors
 > http://localhost:4000/colophon - 0 errors
(node:1988) UnhandledPromiseRejectionWarning: Error: Page crashed!
    at Page._onTargetCrashed (/home/runner/work/accessibility/accessibility/node_modules/puppeteer/lib/Page.js:215:24)
    at CDPSession.<anonymous> (/home/runner/work/accessibility/accessibility/node_modules/puppeteer/lib/Page.js:123:56)
    at CDPSession.emit (events.js:315:20)
    at CDPSession._onMessage (/home/runner/work/accessibility/accessibility/node_modules/puppeteer/lib/Connection.js:200:12)
    at Connection._onMessage (/home/runner/work/accessibility/accessibility/node_modules/puppeteer/lib/Connection.js:112:17)
    at WebSocket.<anonymous> (/home/runner/work/accessibility/accessibility/node_modules/puppeteer/lib/WebSocketTransport.js:44:24)
    at WebSocket.onMessage (/home/runner/work/accessibility/accessibility/node_modules/ws/lib/event-target.js:120:16)
    at WebSocket.emit (events.js:315:20)
    at Receiver.receiverOnMessage (/home/runner/work/accessibility/accessibility/node_modules/ws/lib/websocket.js:789:20)
    at Receiver.emit (events.js:315:20)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:1988) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:1988) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
 > http://localhost:4000/contact - 0 errors
 > http://localhost:4000/conduct - 0 errors
 > http://localhost:4000/news/ - 0 errors
 > http://localhost:4000/join - 0 errors
 > http://localhost:4000/guide - 0 errors
 > http://localhost:4000/license - 0 errors
 > http://localhost:4000/okrs - 0 errors
 > http://localhost:4000/open - 0 errors
 > http://localhost:4000/people - 0 errors
 > http://localhost:4000/personas - 0 errors
 > http://localhost:4000/playbook - 0 errors
 > http://localhost:4000/projects - 0 errors
 > http://localhost:4000/services - 0 errors
 > http://localhost:4000/search - 0 errors
 > http://localhost:4000/VPAT/Drupal9AccessibilityConformanceReport-December2020.html - 0 errors
 > http://localhost:4000/ - Failed to run

Errors in http://localhost:4000/:

 • Error: Pa11y timed out (30000ms)

✘ 71/72 URLs passed
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! uswds-jekyll@ pa11y-ci:sitemap: `pa11y-ci --sitemap http://localhost:4000/sitemap.xml --sitemap-exclude "/*.pdf"`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the uswds-jekyll@ pa11y-ci:sitemap script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2021-04-17T15_16_26_765Z-debug.log

dmundra

Thanks for adding it. Let's see how it goes.

mgifford added 2 commits April 17, 2021 07:54

Initial commit following Jekyll Pure Liquid Heading Anchors

22e4881

https://github.com/allejo/jekyll-anchor-headings

Adding to the Personas page to evaluate

2a633ff

This should turn all of the persona headings into anchor headings.

mgifford mentioned this pull request Apr 17, 2021

Feature request: Add permalinks to heading ID's #261

Closed

dmundra reviewed Apr 17, 2021

View reviewed changes

this will just show content

e87d557

I had wanted to just show the text {{ content }} so it was more clear. what was changed. Just wasn't sure how to comment that without as you noted Daniel duplicating the content.

dmundra self-requested a review April 17, 2021 16:07

dmundra approved these changes Apr 17, 2021

View reviewed changes

mgifford merged commit 0e3744c into main Apr 17, 2021

mgifford deleted the mgifford-patch-1 branch April 17, 2021 17:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing anchor heading permalinks in Playbook pages #271

Implementing anchor heading permalinks in Playbook pages #271

mgifford commented Apr 17, 2021

github-actions bot commented Apr 17, 2021

dmundra Apr 17, 2021

mgifford Apr 17, 2021

github-actions bot commented Apr 17, 2021

dmundra left a comment

Implementing anchor heading permalinks in Playbook pages #271

Implementing anchor heading permalinks in Playbook pages #271

Conversation

mgifford commented Apr 17, 2021

github-actions bot commented Apr 17, 2021

dmundra Apr 17, 2021

Choose a reason for hiding this comment

mgifford Apr 17, 2021

Choose a reason for hiding this comment

github-actions bot commented Apr 17, 2021

dmundra left a comment

Choose a reason for hiding this comment