Fixed claimable GAS calculation #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdschwrtz-zz
pushed a commit
that referenced
this pull request
Feb 3, 2018
dvdschwrtz-zz
pushed a commit
that referenced
this pull request
Feb 14, 2018
mhuggins
added a commit
to neoverse/neon-wallet
that referenced
this pull request
Feb 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
#522 (among others)
What problem does this PR solve?
Calculating claimable GAS can be off due to bad floating point math.
How did you solve this problem?
I replaced floating points with bignumber.js math.
How did you make sure your solution works?
Although this calculation is used for display only, I verified that claiming still works as expected.
I observed the redux store to ensure the calculation is correct. I also claimed to ensure it works as expected. (See screenshot below.) The transaction in the blockchain confirms the correct amount was claimed: http://testnet.neoverse.io/transactions/1a7874a8158eaa84d4cb1180d4196e6d0c5ef450525358e0daa65bf745478f1b
Are there any special changes in the code that we should be aware of?
N/A
Is there anything else we should know?
N/A