CU-376p5gx - If I use the WalletConnect deep link when the wallet is … #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not open it should show the connection modal after I login
|
@raulduartep from now on we need to include at least a minimal description of what changed, and why as well as a relevant title in PRs to the neon wallet repo. This is an open source project and pasting a link to a clickup issue is not enough. Thanks 👍 |
|
@melanke Do not merge this without thorough testing on windows, linux and macOS @raulduartep completely rewrote the way deep linking works with this change |
|
I have confirmed that this is at least working as expected on MacOS nice work @raulduartep 💪 |
comountainclimber
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…not open it should show the connection modal after I login
What current issue(s) from Trello/Github does this address?
What problem does this PR solve?
How did you solve this problem?
How did you make sure your solution works?
Are there any special changes in the code that we should be aware of?
Is there anything else we should know?