Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-864ex6em8 - "Electron's Window Focus" when there is a new WcSdk re… #2509

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

raulduartep
Copy link
Contributor

…quest

What current issue(s) from Trello/Github does this address?

What problem does this PR solve?

How did you solve this problem?

How did you make sure your solution works?

Are there any special changes in the code that we should be aware of?

Is there anything else we should know?

  • Unit tests written?

@lllwvlvwlll
Copy link
Member

@comountainclimber
Copy link
Contributor

When I tested this on MacOS it was not working, the window did not focus when the app was minimized

@melanke
Copy link
Contributor

melanke commented Jul 24, 2023

@comountainclimber can you check again? Thanks

@comountainclimber
Copy link
Contributor

@melanke @raulduartep how are you guys testing this I am a little confused... It still doesnt work on macOS when running yarn dev do I need to create a build?

Copy link
Contributor

@comountainclimber comountainclimber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell this does not work on MacOS

@comountainclimber
Copy link
Contributor

There is still a bug on this branch as I have mentioned above and on discord, the app does not focus when clicking a connection prompt from https://neon.coz.io/connect this should be fixed before merging this PR

@melanke
Copy link
Contributor

melanke commented Aug 1, 2023

There is still a bug on this branch as I have mentioned above and on discord, the app does not focus when clicking a connection prompt from https://neon.coz.io/connect this should be fixed before merging this PR

@comountainclimber I tested this on Windows and it's working on dev branch. It was made on another task.

@comountainclimber comountainclimber merged commit eec1f57 into dev Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants