Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: adds custom network support #2468

Merged
merged 23 commits into from
Mar 23, 2023
Merged

Conversation

comountainclimber
Copy link
Member

@comountainclimber comountainclimber commented Feb 18, 2023

Kapture 2023-02-18 at 13 33 35

FEATURES:

  • Upgrade to React 18 🚀
  • Adds Chakra UI (without implementing any theming, rewriting components etc) to the application for quicker UI development
  • New settings UI, layout and implementation
  • Ability and support for custom/private networks via the settings tab

REFACTORING:

  • Sets up a path forward for completely removing Spunky from the application: if you follow the logic of the refactor in this branch as it applies to the slice of state related to settings you can see that spunky actions have been swapped out for vanilla React context
  • Removes a bunch of unnecessary higher order components
  • Adds a withSettingsContext HOC as a drop in replacement for some of the others

TODO:

  • Implement toast notifications when network or other settings update
  • Add translations back to settings screens
  • Disable activity, NFT tab etc
  • Wallet connect testing??
  • More thorough manual regression testing, this massive PR touches almost every feature in the application
  • Link to settings from network activity tab and from the custom network label
  • Implement links for recover and encrypt key
  • Network configuration tooltip needs to route => settings
  • There needs to still be a way to navigate to to node select panel if a user is on private/main nets
  • Switching chains needs to reset network settings
  • Fix label for when user is on anything other than the default
  • Remove ability to add private net on legacy
  • Add the ability to save different networks with names

QUESTIONS:

  • Do we want to disable some of the navigation tabs when on a private network?
  • Should we remove block explorer as a choice in settings? (Dora offers support for both chains)

@comountainclimber comountainclimber merged commit 18e4699 into dev Mar 23, 2023
@comountainclimber comountainclimber deleted the feature/privatenet branch September 23, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant