CU-864dz6z38 - Wc: When not sending a signature scope the wallet shou… #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld use the default (CalledByEntry, not None. None would be if the developer explicitly says None)
raulduartep
force-pushed
the
CU-864dz6z38
branch
from
1c80ff3 to
582bb01
Compare
| @@ -427,6 +427,8 @@ const ApproveTransaction = ({ | |||
| String(request.params.request.params.signers[0]?.scopes) | |||
| ] === 'Global' && <WarningIcon />} | |||
| </div> | |||
| ) : ( | |||
| <div>{WITNESS_SCOPE['1']}</div> | |||
There was a problem hiding this comment.
Shouldn't this be WITNESS_SCOPE[1]? Why is this a string
There was a problem hiding this comment.
Because the key for this const is a string. if you look on the line 28, the WITNESS_SCOPE is a const.
| signer.scopes = signerEntry && signerEntry.scopes | ||
| signer.scopes = signerEntry | ||
| ? signerEntry.scopes | ||
| : tx.WitnessScope.CalledByEntry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ld use the default (CalledByEntry, not None. None would be if the developer explicitly says None)
What current issue(s) from Trello/Github does this address?
What problem does this PR solve?
How did you solve this problem?
How did you make sure your solution works?
Are there any special changes in the code that we should be aware of?
Is there anything else we should know?