CU-864dmfjy9 - Upgrade Ghost Market API to v2 #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-864dmfjy9 Upgrade Ghost Market API to v2 |
app/actions/nftGalleryActions.js
Outdated
| ) | ||
|
|
||
| // eslint-disable-next-line no-console | ||
| console.log(results) |
There was a problem hiding this comment.
We should probably remove this log
There was a problem hiding this comment.
I forgot to remove this log. Solved
app/actions/nftGalleryActions.js
Outdated
|
|
||
| return { results: previousResults.concat(results), page, count } | ||
| } | ||
| if (!assets || !assets.length || !count) throw new Error('No assets found') |
There was a problem hiding this comment.
I think keeping the previous pattern of returning an empty payload makes more sense than returning an error here as there is no error that occurred - no NFT's is not really an error
raulduartep
force-pushed
the
CU-864dmfjy9
branch
from
f5ef53f to
87b75ec
Compare
comountainclimber
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
What problem does this PR solve?
How did you solve this problem?
How did you make sure your solution works?
Are there any special changes in the code that we should be aware of?
Is there anything else we should know?