CU-2pjkxye - No visible QR code #2426
Conversation
| @@ -45,7 +45,7 @@ export default function withCopyCanvasToClipboard(Component) { | |||
| // $FlowFixMe | |||
| const url = ref.toDataURL('image/jpg', 0.8) | |||
| const base64Data = url.replace(/^data:image\/png;base64,/, '') | |||
| const storagePath = storage.getDefaultDataPath() | |||
| const storagePath = storage.getDataPath() | |||
There was a problem hiding this comment.
I am pretty sure this is not going to give you the path we use everywhere else in the application... We should be using const path = await ipcRenderer.invoke('getStoragePath') here
There was a problem hiding this comment.
All right. I was a bit confused on how to get the storage path. Thanks for the alert, I will fix this.
| renderHeaderIcon={HeaderIcon} | ||
| renderInstructions={ | ||
| encryptedWIF | ||
| ? () => intl.formatMessage({ id: 'encryptInstructions' }) |
There was a problem hiding this comment.
We should skip the instructions part OR make the instructions say something different than "Choose a passphrase to encrypt an existing key" like "please save your information in a safe place" once they have successfully encrypted a key (at this point they have already chosen a passphrase)
There was a problem hiding this comment.
Ok. You are right. I will fix.
|
Two minor things I noticed when reviewing this... Nice work @raulduartep !! 💪 |
raulduartep
force-pushed
the
NWD-CU-2pjkxye
branch
from
3e2db74 to
6156058
Compare
|
@raulduartep please let me know when the feedback has been addressed and merge conflicts are resolved 👀 |
raulduartep
force-pushed
the
NWD-CU-2pjkxye
branch
from
6156058 to
4e95189
Compare
What current issue(s) from Trello/Github does this address?
What problem does this PR solve?
How did you solve this problem?
How did you make sure your solution works?
Are there any special changes in the code that we should be aware of?
Is there anything else we should know?