feature: dependency overhaul #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,7 +2,8 @@ const path = require('path') | |||
| const webpack = require('webpack') | |||
| const HtmlWebpackPlugin = require('html-webpack-plugin') | |||
| const UglifyJSPlugin = require('uglifyjs-webpack-plugin') | |||
| const ExtractTextPlugin = require('extract-text-webpack-plugin') | |||
There was a problem hiding this comment.
ExtractTextPlugin is deprecated and incompatible with node 16.14.2
| "electron": "^10.0.0", | ||
| "electron-builder": "22.11.11", | ||
| "css-loader": "4.2.0", | ||
| "electron": "19.0.8", |
| @@ -222,15 +224,14 @@ | |||
| "identity-obj-proxy": "3.0.0", | |||
| "jest": "22.4.2", | |||
| "json-loader": "0.5.7", | |||
| "node-sass": "4.13.1", | |||
There was a problem hiding this comment.
node-sass is another deprecated project incompatible with electron 19 and node 16
| @@ -1,9 +1,20 @@ | |||
| import { ipcRenderer } from 'electron' | |||
There was a problem hiding this comment.
The storage module needed to be refactored for some reason the default path it was using changed during the electron update. Its working exactly as expected with these changes
melanke
approved these changes
Aug 5, 2022
| @@ -85,6 +85,7 @@ app.on('ready', () => { | |||
| contextIsolation: true, | |||
| webPreferences: { | |||
| enableRemoteModule: true, | |||
| contextIsolation: false, | |||
There was a problem hiding this comment.
This was already turned off in our previous builds but the setting has changed to defaulting to true in new versions of electron thus requiring this explicit flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
What problem does this PR solve?
How did you solve this problem?
How did you make sure your solution works?
Are there any special changes in the code that we should be aware of?
Is there anything else we should know?