Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: fixes bugs found in 2.12.8 #2410

Merged
merged 3 commits into from
May 2, 2022

Conversation

comountainclimber
Copy link
Member

What current issue(s) from Trello/Github does this address?

What problem does this PR solve?

How did you solve this problem?

How did you make sure your solution works?

Are there any special changes in the code that we should be aware of?

Is there anything else we should know?

  • Unit tests written?

try {
if (chain === 'neo2') return parseQRCode(url)
if (chain === 'neo2' || url.includes('neo:'))
return parseQRCode({ url, net, chain })
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will attempt to parse the nep9 QR code if it includes protocol otherwise we will just assume it is an address

@@ -58,10 +58,10 @@ export default class LoginPrivateKey extends React.Component<Props, State> {
<React.Fragment>
<div className={styles.scannerContainer}>
<QrCodeScanner
callback={() =>
callback={key =>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what was breaking the login flow 🙈

@comountainclimber comountainclimber merged commit 71ff597 into dev May 2, 2022
@comountainclimber comountainclimber deleted the feature/qr-enhancements-II branch August 10, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant