Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/pre release changes #2346

Merged
merged 3 commits into from
Dec 21, 2021
Merged

Feat/pre release changes #2346

merged 3 commits into from
Dec 21, 2021
+47 −199

Conversation

lllwvlvwlll
Copy link
Member

@lllwvlvwlll lllwvlvwlll commented Dec 20, 2021 •
edited
Loading

This PR implements a number of updates to the handling of wallet connect:

  • Removes code from degraded code paths (testInvoke and invokeFunction)
  • Updates a styling overflow on the approve transaction overlay for arrays with long valued indices
  • Simplifies and aligns code paths for transaction building from requests
  • Resolves defect in ledger signing associated with requests which were not CallByEntry or Global
  • Updates request types to align with wallet-connect-sdk-core v1.6.0

@comountainclimber If you merge and stage this as a draft release, I will upload the windows build and push it into production.
@vincentgeneste has already verified this is working for all ghost market methods. I have verified it against quickvote-dev and have a release staged for production.

@lllwvlvwlll lllwvlvwlll merged commit 8b04751 into dev Dec 21, 2021
@comountainclimber comountainclimber deleted the feat/preReleaseChanges branch August 10, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comountainclimber comountainclimber comountainclimber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lllwvlvwlll @comountainclimber