Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GHOST logos #2331

Merged
merged 3 commits into from
Nov 29, 2021
Merged

add GHOST logos #2331

merged 3 commits into from
Nov 29, 2021

Conversation

vincentgeneste
Copy link
Contributor

@vincentgeneste vincentgeneste commented Nov 22, 2021

What problem does this PR solve?

Fixing that:

Screen Shot 2021-11-21 at 7 14 58 PM

How did you solve this problem?

adding logos

@@ -47,6 +47,7 @@ import WWB from './WWB.svg'
import XQTA from './XQTA.svg'
import ZPT from './ZPT.svg'
import NOS from './NOS.svg'
import GHOST from './GHOST.svg'

export const imageMap = {
NEO,
Copy link
Contributor

@comountainclimber comountainclimber Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are not also exporting the asset here this code is noop... Have you verified that this PR works? If it does I am super confused as to how its working

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haerm, my bad it's a miss on the PR, will fix now.

Copy link
Contributor

@comountainclimber comountainclimber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@comountainclimber comountainclimber merged commit 3b14d7e into CityOfZion:dev Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants